From: Vivek Goyal <vgoyal@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] overlay/016: split into two tests
Date: Fri, 1 Jun 2018 10:45:43 -0400 [thread overview]
Message-ID: <20180601144543.GC3259@redhat.com> (raw)
In-Reply-To: <1527849857-22951-3-git-send-email-amir73il@gmail.com>
On Fri, Jun 01, 2018 at 01:44:17PM +0300, Amir Goldstein wrote:
[..]
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +
> +# real QA test starts here
> +_supported_fs overlay
> +_supported_os Linux
> +_require_scratch
> +_require_scratch_feature copy_up_shared
> +_require_xfs_io_command "open"
> +
> +rm -f $seqres.full
> +
> +_scratch_mkfs >>$seqres.full 2>&1
> +
> +# Create our test files.
> +lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER
> +mkdir -p $lowerdir
> +echo "This is old news" > $lowerdir/foo
foo is not being used in this new test now. Similarly, bar is not being
used in 016. May be just get rid of file "bar" and just use file
"foo" in both the tests.
Vivek
prev parent reply other threads:[~2018-06-01 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 10:44 [PATCH 0/2] Overlayfs tests for consistent ro/rw fd Amir Goldstein
2018-06-01 10:44 ` [PATCH 1/2] overlay: nicer report when features are not supported Amir Goldstein
2018-06-01 10:44 ` [PATCH 2/2] overlay/016: split into two tests Amir Goldstein
2018-06-01 14:45 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601144543.GC3259@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.