From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbeFAQEN (ORCPT ); Fri, 1 Jun 2018 12:04:13 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751913AbeFAQEK (ORCPT ); Fri, 1 Jun 2018 12:04:10 -0400 Date: Fri, 1 Jun 2018 18:04:07 +0200 From: Oleg Nesterov To: Christian Brauner Cc: linux-kernel@vger.kernel.org, ebiederm@xmission.com, gregkh@linuxfoundation.org, mingo@kernel.org, james.morris@microsoft.com, keescook@chromium.org, peterz@infradead.org, sds@tycho.nsa.gov, viro@zeniv.linux.org.uk, akpm@linux-foundation.org Subject: Re: [PATCH v2 05/17] signal: simplify rt_sigaction() Message-ID: <20180601160407.GC1058@redhat.com> References: <20180601132239.4421-1-christian@brauner.io> <20180601132239.4421-6-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180601132239.4421-6-christian@brauner.io> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01, Christian Brauner wrote: > > The goto is not needed and does not add any clarity. Simply return -EINVAL > on unexpected sigset_t struct size directly. Agreed, sys_rt_sigaction() looks just ugly and mixes goto/return on failure, ACK