All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dave Chiluk <dchiluk@indeed.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 0/1] Fix for xfs agfl wrap crash for stable kernels
Date: Fri, 1 Jun 2018 19:07:45 +0200	[thread overview]
Message-ID: <20180601170745.GB13517@kroah.com> (raw)
In-Reply-To: <20180531234147.13608-1-chiluk+linux@indeed.com>

On Thu, May 31, 2018 at 06:41:46PM -0500, Dave Chiluk wrote:
> When moving xfs volumes between kernels that have 96f859d52 and don't
> have 96f859d52, there is potential for a filesystem crash if the agfl
> has wrapped (flfirst > fllast).  Depending on which filesystem this is
> this can take down the whole machine.
> 
> Such is the case when upgrading from the stock Centos 7 3.13 to the
> kernel.org stable kernels (via elrepo).  Another possible common
> boundary cross I noticed was early Ubuntu kernel v4.4 to recent v4.4.
> We've been hitting this crash roughly once a week in our cloud, and it
> has produced the below stack trace.
> 
> The solution prefers to reset the agfl and leak a few blocks instead of
> shutting down the filesystem.  The leaked blocks can be recovered using
> a xfs_repair.
> 
> The attached patch is a backport of a27ba2607 due to a78ee256c.  It is
> intended for and tested on the v4.4 stream, but should apply to all
> kernels that lack upstream a78ee256c.  

Thanks, now queued up.

greg k-h

      parent reply	other threads:[~2018-06-01 17:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 23:41 [PATCH 0/1] Fix for xfs agfl wrap crash for stable kernels Dave Chiluk
2018-05-31 23:41 ` [PATCH] xfs: detect agfl count corruption and reset agfl Dave Chiluk
2018-06-01 17:07 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601170745.GB13517@kroah.com \
    --to=greg@kroah.com \
    --cc=dchiluk@indeed.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.