From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 0/4] RFC CPSW switchdev mode Date: Sun, 3 Jun 2018 02:26:18 +0200 Message-ID: <20180603002618.GB14515@lunn.ch> References: <1527144984-31236-1-git-send-email-ilias.apalodimas@linaro.org> <20180524080528.GD2295@nanopsycho> <20180524084831.GA2759@apalos> <20180524125431.GB24557@lunn.ch> <7437d485-1eac-9619-3827-5af9b32b939e@redhat.com> <20180524140831.GA16793@apalos> <2b3cabca-4710-0a71-69c7-cc433e2b3062@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ilias Apalodimas , Ivan Vecera , Jiri Pirko , netdev@vger.kernel.org, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com To: Grygorii Strashko Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:52664 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbeFCA0W (ORCPT ); Sat, 2 Jun 2018 20:26:22 -0400 Content-Disposition: inline In-Reply-To: <2b3cabca-4710-0a71-69c7-cc433e2b3062@ti.com> Sender: netdev-owner@vger.kernel.org List-ID: > *After this patch set*: goal keep things working the same as max as > possible and get rid of TI custom tool. We are happy to keep things the same, if they fit with the switchdev model. Anything in your customer TI tool/model which does not fit the switchdev model you won't be able to keep, except if we agree to extend the model. I can say now, sw0p0 is going to cause problems. I really do suggest you drop it for the moment in order to get a minimal driver accepted. sw0p0 does not fit the switchdev model. > Below I've described some tested use cases (not include full static configuration), > but regarding sw0p0 - there is work done by Ivan Khoronzhuk [1] which enables > adds MQPRIO and CBS Qdisc and targets AVB network features. It required to > offload MQPRIO and CBS parameters on all ports including P0. In case of P0, > CPDMA TX channels shapers need to be configured, and in case > of sw0p1/sw0p2 internal FIFOS. > sw0p0 also expected to be used to configure CPDMA interface in general - > number of tx/rx channels, rates, ring sizes. Can this be derives from the configuration on sw0p1 and sw0p2? sw0p1 has 1 tx channel, sw0p2 has 2 tx channels, so give p0 3 tx channels? > In addition there is set of global CPSW parameters (not related to P1/P2, like > MAC Authorization Mode, OUI Deny Mode, crc ) which I've > thought can be added to sw0p0 (using ethtool -priv-flags). You should describe these features, and then we can figure out how best to model them. devlink might be an option if they are switch global. Andrew