All of lore.kernel.org
 help / color / mirror / Atom feed
From: Teddy Reed <teddy.reed@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] vboot: Do not use hashed-strings offset
Date: Sun, 3 Jun 2018 14:46:50 -0400	[thread overview]
Message-ID: <20180603144650.0a2f1ac5840f3276efdb8a34@gmail.com> (raw)


The hashed-strings signature property includes two uint32_t values.
The first is unneeded as there should never be a start offset into the
strings region. The second, the size, is needed because the added
signature node appends to this region.

See tools/image-host.c, where a static 0 value is used for the offset.

Signed-off-by: Teddy Reed <teddy.reed@gmail.com>
---
 common/image-sig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/common/image-sig.c b/common/image-sig.c
index f65d883..9b0a872 100644
--- a/common/image-sig.c
+++ b/common/image-sig.c
@@ -372,8 +372,7 @@ int fit_config_check_sig(const void *fit, int noffset, int required_keynode,
 	/* Add the strings */
 	strings = fdt_getprop(fit, noffset, "hashed-strings", NULL);
 	if (strings) {
-		fdt_regions[count].offset = fdt_off_dt_strings(fit) +
-				fdt32_to_cpu(strings[0]);
+		fdt_regions[count].offset = fdt_off_dt_strings(fit);
 		fdt_regions[count].size = fdt32_to_cpu(strings[1]);
 		count++;
 	}
-- 
2.7.4

             reply	other threads:[~2018-06-03 18:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03 18:46 Teddy Reed [this message]
2018-06-07 20:28 ` [U-Boot] [PATCH] vboot: Do not use hashed-strings offset Simon Glass
2018-06-07 21:58   ` Teddy Reed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180603144650.0a2f1ac5840f3276efdb8a34@gmail.com \
    --to=teddy.reed@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.