From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Huth <thuth@redhat.com>,
"Jason J . Herne" <jjherne@linux.ibm.com>,
"Collin L . Walling" <walling@linux.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v1 5/7] s390x/tcg: implement SET CLOCK
Date: Mon, 4 Jun 2018 14:05:47 +0200 [thread overview]
Message-ID: <20180604140547.68c95e17.cohuck@redhat.com> (raw)
In-Reply-To: <20180525113708.29856-6-david@redhat.com>
On Fri, 25 May 2018 13:37:06 +0200
David Hildenbrand <david@redhat.com> wrote:
> This allows a guest to change its TOD. We already take care of updating
> all CKC timers from within S390TODClass.
>
> Use MO_ALIGN to load the operand manually - this will properly trigger a
> SPECIFICATION exception.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/helper.h | 1 +
> target/s390x/insn-data.def | 3 +--
> target/s390x/misc_helper.c | 19 +++++++++++++++++++
> target/s390x/translate.c | 9 +++++++++
> 4 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
> index 2ef9de1cca..2f5cd6d22a 100644
> --- a/target/s390x/misc_helper.c
> +++ b/target/s390x/misc_helper.c
> @@ -191,6 +191,25 @@ void tcg_s390_tod_updated(CPUState *cs, run_on_cpu_data opaque)
> helper_sckc(env, env->ckc);
> }
>
> +/* Set Clock */
> +uint32_t HELPER(sck)(CPUS390XState *env, uint64_t tod_low)
> +{
> + S390TODState *td = s390_get_tod();
> + S390TODClass *tdc = S390_TOD_GET_CLASS(td);
Would it make sense to cache the class as well?
> + S390TOD tod = {
> + .high = 0,
> + .low = tod_low,
> + };
> + Error *err = NULL;
> +
> + qemu_mutex_lock_iothread();
> + tdc->set(td, &tod, &err);
> + qemu_mutex_unlock_iothread();
> + g_assert(!err);
> +
> + return 0;
> +}
> +
next prev parent reply other threads:[~2018-06-04 12:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 11:37 [Qemu-devel] [PATCH v1 0/7] s390x: TOD refactoring + TCG CPU hotplug support David Hildenbrand
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 1/7] s390x/tod: factor out TOD into separate device David Hildenbrand
2018-06-04 11:38 ` Cornelia Huck
2018-06-04 12:00 ` David Hildenbrand
2018-06-04 12:14 ` Cornelia Huck
2018-06-07 10:49 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-06-07 11:10 ` Cornelia Huck
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 2/7] s390x/tcg: drop tod_basetime David Hildenbrand
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 3/7] s390x/tcg: properly implement the TOD David Hildenbrand
2018-06-04 11:57 ` Cornelia Huck
2018-06-04 11:59 ` David Hildenbrand
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 4/7] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts David Hildenbrand
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 5/7] s390x/tcg: implement SET CLOCK David Hildenbrand
2018-06-04 12:05 ` Cornelia Huck [this message]
2018-06-07 10:48 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-06-07 11:15 ` Cornelia Huck
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 6/7] s390x/tcg: rearm the CKC timer during migration David Hildenbrand
2018-06-04 12:09 ` Cornelia Huck
2018-06-07 10:47 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-05-25 11:37 ` [Qemu-devel] [PATCH v1 7/7] s390x/tcg: fix CPU hotplug with single-threaded TCG David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604140547.68c95e17.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.