All of lore.kernel.org
 help / color / mirror / Atom feed
From: chandan.vn@samsung.com (CHANDAN VN)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] Smack: Fix memory leak in smack_inode_getsecctx
Date: Tue, 05 Jun 2018 20:16:50 +0530	[thread overview]
Message-ID: <20180605144650epcms5p4cdc56b9a80e72b2ba189a2786419a074@epcms5p4> (raw)
In-Reply-To: <9fdb7658-0440-4402-cda6-7f1426ea24e6@schaufler-ca.com>

?
?
>On?6/5/2018?12:04?AM,?CHANDAN?VN?wrote:
>>??
>>
>>>?On?Mon,?Jun?04,?2018?at?02:01:34PM?-0700,?Casey?Schaufler?wrote:
>>>>??On?6/1/2018?10:45?AM,?Casey?Schaufler?wrote:
>>>>??>?Fix?memory?leak?in?smack_inode_getsecctx
>>>>??>
>>>>??>?The?implementation?of?smack_inode_getsecctx()?made
>>>>??>?incorrect?assumptions?about?how?Smack?presents?a?security
>>>>??>?context.?Smack?does?not?need?to?allocate?memory?to?support
>>>>??>?security?contexts,?so?"releasing"?a?Smack?context?is?a?no-op.
>>>>??>?The?code?made?an?unnecessary?copy?and?returned?that?as?a
>>>>??>?context,?which?was?never?freed.?The?revised?implementation
>>>>??>?returns?the?context?correctly.
>>>>??>
>>>>??>?Signed-off-by:?Casey?Schaufler?<casey@schaufler-ca.com>
>>>>??
>>>>??Tejun,?does?this?pass?your?tests?
>>??
>>>?Oh,?I'm?not?the?one?who?reported.??Chandan?
>>?Looks?good?to?me.?Leak?not?found.
>?
>Thanks.?Can?I?add?your?"Tested-by:"?on?the?commit?

Sure. I think "Reported-by:" would also be ok.
?
?
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2018-06-05 14:46 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcas1p2.samsung.com>
2018-05-31  9:28 ` [PATCH 1/1] Fix memory leak in kernfs_security_xattr_set and kernfs_security_xattr_set CHANDAN VN
2018-05-31 15:26   ` Casey Schaufler
2018-05-31 20:57     ` Eric W. Biederman
2018-05-31 21:08       ` Casey Schaufler
2018-05-31 15:39   ` Tejun Heo
2018-05-31 15:39     ` Tejun Heo
2018-05-31 16:04     ` Casey Schaufler
2018-05-31 16:04       ` Casey Schaufler
2018-05-31 16:11       ` Tejun Heo
2018-05-31 16:11         ` Tejun Heo
2018-05-31 16:22         ` Casey Schaufler
2018-05-31 16:22           ` Casey Schaufler
     [not found]         ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p5>
2018-06-01  8:56           ` CHANDAN VN
2018-06-01  8:56             ` CHANDAN VN
2018-06-01  8:56             ` CHANDAN VN
2018-06-01 16:22             ` Casey Schaufler
2018-06-01 16:22               ` Casey Schaufler
     [not found]             ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p7>
2018-06-01 16:29               ` CHANDAN VN
2018-06-01 16:29                 ` CHANDAN VN
2018-06-01 16:29                 ` CHANDAN VN
2018-06-01 16:41                 ` Casey Schaufler
2018-06-01 16:41                   ` Casey Schaufler
2018-06-01 17:45                   ` [PATCH] Smack: Fix memory leak in smack_inode_getsecctx Casey Schaufler
2018-06-01 17:45                     ` Casey Schaufler
2018-06-04 21:01                     ` Casey Schaufler
2018-06-04 21:01                       ` Casey Schaufler
2018-06-04 21:27                       ` Tejun Heo
2018-06-04 21:27                         ` Tejun Heo
     [not found]                       ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p3>
2018-06-05  7:04                         ` CHANDAN VN
2018-06-05  7:04                           ` CHANDAN VN
2018-06-05  7:04                           ` CHANDAN VN
2018-06-05 14:29                           ` Casey Schaufler
     [not found]                           ` <CGME20180531092848epcas1p24b638ccd6da00f1e039bdb64de7e1a5b@epcms5p4>
2018-06-05 14:46                             ` CHANDAN VN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605144650epcms5p4cdc56b9a80e72b2ba189a2786419a074@epcms5p4 \
    --to=chandan.vn@samsung.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.