From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbeFEPZs (ORCPT ); Tue, 5 Jun 2018 11:25:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:38342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbeFEPZr (ORCPT ); Tue, 5 Jun 2018 11:25:47 -0400 Date: Tue, 5 Jun 2018 17:25:24 +0200 From: Greg Kroah-Hartman To: Anurag Kumar Vulisha Cc: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: host: xhci-plat: Iterate over parent nodes for finding quirks Message-ID: <20180605152524.GA23280@kroah.com> References: <1528212056-28390-1-git-send-email-anurag.kumar.vulisha@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528212056-28390-1-git-send-email-anurag.kumar.vulisha@xilinx.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 05, 2018 at 08:50:56PM +0530, Anurag Kumar Vulisha wrote: > In xhci_plat_probe() both sysdev and pdev->dev are being used > for finding quirks. There are some drivers(like dwc3 host.c) > which adds quirks(like usb3-lpm-capable) into pdev and the logic > present in xhci_plat_probe() checks for quirks in either sysdev > or pdev for finding the quirks. Because of this logic, some of > the quirks are getting missed(usb3-lpm-capable quirk added by dwc3 > host.c driver is getting missed).This patch fixes this by iterating > over all the available parents for finding the quirks. In this way > all the quirks which are present in child or parent are correctly > updated. > > Signed-off-by: Anurag Kumar Vulisha So this is a bugfix? If so, how far back in the kernel releases should it go to? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: host: xhci-plat: Iterate over parent nodes for finding quirks From: Greg Kroah-Hartman Message-Id: <20180605152524.GA23280@kroah.com> Date: Tue, 5 Jun 2018 17:25:24 +0200 To: Anurag Kumar Vulisha Cc: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBKdW4gMDUsIDIwMTggYXQgMDg6NTA6NTZQTSArMDUzMCwgQW51cmFnIEt1bWFyIFZ1 bGlzaGEgd3JvdGU6Cj4gSW4geGhjaV9wbGF0X3Byb2JlKCkgYm90aCBzeXNkZXYgYW5kIHBkZXYt PmRldiBhcmUgYmVpbmcgdXNlZAo+IGZvciBmaW5kaW5nIHF1aXJrcy4gVGhlcmUgYXJlIHNvbWUg ZHJpdmVycyhsaWtlIGR3YzMgaG9zdC5jKQo+IHdoaWNoIGFkZHMgcXVpcmtzKGxpa2UgdXNiMy1s cG0tY2FwYWJsZSkgaW50byBwZGV2IGFuZCB0aGUgbG9naWMKPiBwcmVzZW50IGluIHhoY2lfcGxh dF9wcm9iZSgpIGNoZWNrcyBmb3IgcXVpcmtzIGluIGVpdGhlciBzeXNkZXYKPiBvciBwZGV2IGZv ciBmaW5kaW5nIHRoZSBxdWlya3MuIEJlY2F1c2Ugb2YgdGhpcyBsb2dpYywgc29tZSBvZgo+IHRo ZSBxdWlya3MgYXJlIGdldHRpbmcgbWlzc2VkKHVzYjMtbHBtLWNhcGFibGUgcXVpcmsgYWRkZWQg YnkgZHdjMwo+IGhvc3QuYyBkcml2ZXIgaXMgZ2V0dGluZyBtaXNzZWQpLlRoaXMgcGF0Y2ggZml4 ZXMgdGhpcyBieSBpdGVyYXRpbmcKPiBvdmVyIGFsbCB0aGUgYXZhaWxhYmxlIHBhcmVudHMgZm9y IGZpbmRpbmcgdGhlIHF1aXJrcy4gSW4gdGhpcyB3YXkKPiBhbGwgdGhlIHF1aXJrcyB3aGljaCBh cmUgcHJlc2VudCBpbiBjaGlsZCBvciBwYXJlbnQgYXJlIGNvcnJlY3RseQo+IHVwZGF0ZWQuCj4g Cj4gU2lnbmVkLW9mZi1ieTogQW51cmFnIEt1bWFyIFZ1bGlzaGEgPGFudXJhZy5rdW1hci52dWxp c2hhQHhpbGlueC5jb20+CgpTbyB0aGlzIGlzIGEgYnVnZml4PyAgSWYgc28sIGhvdyBmYXIgYmFj ayBpbiB0aGUga2VybmVsIHJlbGVhc2VzIHNob3VsZAppdCBnbyB0bz8KCnRoYW5rcywKCmdyZWcg ay1oCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5z dWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21v QHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJu ZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK