From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbeFETlh (ORCPT ); Tue, 5 Jun 2018 15:41:37 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:34161 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbeFETl2 (ORCPT ); Tue, 5 Jun 2018 15:41:28 -0400 X-Google-Smtp-Source: ADUXVKK2nCRHsh0sHLWhVqEbrUcUGPzD9g/gL1OIcw1xeG3x2bxydPDtqcUcOfgBv7j9sXdivPwzcw== Date: Tue, 5 Jun 2018 13:41:24 -0600 From: Rob Herring To: Ray Jui Cc: Wim Van Sebroeck , Guenter Roeck , Mark Rutland , Frank Rowand , Catalin Marinas , Will Deacon , Robin Murphy , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v4 1/6] Documentation: DT: Consolidate SP805 binding docs Message-ID: <20180605194124.GA26885@rob-hp-laptop> References: <1527530497-10392-1-git-send-email-ray.jui@broadcom.com> <1527530497-10392-2-git-send-email-ray.jui@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527530497-10392-2-git-send-email-ray.jui@broadcom.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 28, 2018 at 11:01:32AM -0700, Ray Jui wrote: > Consolidate two SP805 binding documents "arm,sp805.txt" and > "sp805-wdt.txt" into "arm,sp805.txt" that matches the naming of the > desired compatible string to be used > > Signed-off-by: Ray Jui > --- > .../devicetree/bindings/watchdog/arm,sp805.txt | 27 ++++++++++++++----- > .../devicetree/bindings/watchdog/sp805-wdt.txt | 31 ---------------------- > 2 files changed, 20 insertions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/sp805-wdt.txt Would be good to get a ACK from FSL/NXP person on this. It looks to me like the driver fetches the wrong clock as it gets the first one and the driver really wants 'wdog_clk'. In any case, their dts files should be updated. Reviewed-by: Rob Herring Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Tue, 5 Jun 2018 13:41:24 -0600 Subject: [PATCH v4 1/6] Documentation: DT: Consolidate SP805 binding docs In-Reply-To: <1527530497-10392-2-git-send-email-ray.jui@broadcom.com> References: <1527530497-10392-1-git-send-email-ray.jui@broadcom.com> <1527530497-10392-2-git-send-email-ray.jui@broadcom.com> Message-ID: <20180605194124.GA26885@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 28, 2018 at 11:01:32AM -0700, Ray Jui wrote: > Consolidate two SP805 binding documents "arm,sp805.txt" and > "sp805-wdt.txt" into "arm,sp805.txt" that matches the naming of the > desired compatible string to be used > > Signed-off-by: Ray Jui > --- > .../devicetree/bindings/watchdog/arm,sp805.txt | 27 ++++++++++++++----- > .../devicetree/bindings/watchdog/sp805-wdt.txt | 31 ---------------------- > 2 files changed, 20 insertions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/sp805-wdt.txt Would be good to get a ACK from FSL/NXP person on this. It looks to me like the driver fetches the wrong clock as it gets the first one and the driver really wants 'wdog_clk'. In any case, their dts files should be updated. Reviewed-by: Rob Herring Rob