From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8463B60263 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932309AbeFFG6Z (ORCPT + 25 others); Wed, 6 Jun 2018 02:58:25 -0400 Received: from mail.bootlin.com ([62.4.15.54]:37366 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932239AbeFFG6X (ORCPT ); Wed, 6 Jun 2018 02:58:23 -0400 Date: Wed, 6 Jun 2018 08:58:11 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Viresh Kumar , arm-soc , Rob Herring , Mark Rutland , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree , linux-arm-kernel , linux-kernel Subject: Re: [PATCH V2 2/2] arm: dts: sunxi: Add missing cooling device properties for CPUs Message-ID: <20180606065811.moklm4pbrhleasly@flea> References: <20180601151701.sshwfdbflic6mybv@flea> <20180605071139.osu2pgpg3ychdxln@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yyunednjohhozaln" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180512 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yyunednjohhozaln Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 06, 2018 at 12:02:20AM +0800, Chen-Yu Tsai wrote: > On Tue, Jun 5, 2018 at 3:11 PM, Maxime Ripard = wrote: > > On Tue, Jun 05, 2018 at 10:17:49AM +0530, Viresh Kumar wrote: > >> The cooling device properties, like "#cooling-cells" and > >> "dynamic-power-coefficient", should either be present for all the CPUs > >> of a cluster or none. If these are present only for a subset of CPUs of > >> a cluster then things will start falling apart as soon as the CPUs are > >> brought online in a different order. For example, this will happen > >> because the operating system looks for such properties in the CPU node > >> it is trying to bring up, so that it can register a cooling device. > >> > >> Add such missing properties. > >> > >> Fix other missing properties (clocks, OPP, clock latency) as well to > >> make it all work. > >> > >> Signed-off-by: Viresh Kumar > > > > Applied both, thanks! >=20 > Please fix the "ARM" prefix when applying. :) Done, thanks for the reminder :) Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --yyunednjohhozaln Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlsXhgIACgkQ0rTAlCFN r3SpHw//Q0Tq2mev9+RBCUU4pHRg4oFhrh8cuVYbAENhw3Lsld3QjfDM0OlUubg2 cJHQNbpZzKmNg3Of2U2BIR2ZWOncQNItn7tCwZ7p6hGtM3AO72Zv1bzwyHnZUIOm 22biaTtyF5TPO4m4sThbVa0xo2lpYBcNbM4ZZiH5Ss8pObpJeZBysHTAvXb/TKPW l5rlTO08NfFSF1XfyUNmJtGQAOSoGC+Wb+0vSxVOsMdSfMvuTbRa8Lx18f2xuMNL kTLsrGUir9RjWE/33M0SUEmFONKAmbZUpyEiazBsmIFQ6HqFq+1/oNPg0AKeV2M5 cJSbRutZl0/hao4Jqu4P4mdsWarTPHyN22Tuh3mORauBcRuM95ro8sNfxCFHRKit AOEFGn3MarZymmzVVegctwZfQkSprspmWE9WdH867zViKK1d6nNrl9iN8eYhX6De HVTUeyEgVdxxVIT3XBOfuenBr36mnxus0xgRZxrxuyNfcOE8225vPhnfT/xEhSj0 bPvhLj6oXWPJFkcxd+sXe+LgK7Qogm7Zz55zU6yCzN9zU/LLfiCP2YS3ftl83leY gHKp6Al5cpNqeegjMGKiKqzZZAYURooyFcLSe6g4xcRFxoRvYwza+UGxcNhwk38x W3ze64MAfwqCYqDvyKVwKHRlOqqu2Dv3PucN3MMhEIOHbHe+fRE= =Osr5 -----END PGP SIGNATURE----- --yyunednjohhozaln-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Wed, 6 Jun 2018 08:58:11 +0200 Subject: [PATCH V2 2/2] arm: dts: sunxi: Add missing cooling device properties for CPUs In-Reply-To: References: <20180601151701.sshwfdbflic6mybv@flea> <20180605071139.osu2pgpg3ychdxln@flea> Message-ID: <20180606065811.moklm4pbrhleasly@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 06, 2018 at 12:02:20AM +0800, Chen-Yu Tsai wrote: > On Tue, Jun 5, 2018 at 3:11 PM, Maxime Ripard wrote: > > On Tue, Jun 05, 2018 at 10:17:49AM +0530, Viresh Kumar wrote: > >> The cooling device properties, like "#cooling-cells" and > >> "dynamic-power-coefficient", should either be present for all the CPUs > >> of a cluster or none. If these are present only for a subset of CPUs of > >> a cluster then things will start falling apart as soon as the CPUs are > >> brought online in a different order. For example, this will happen > >> because the operating system looks for such properties in the CPU node > >> it is trying to bring up, so that it can register a cooling device. > >> > >> Add such missing properties. > >> > >> Fix other missing properties (clocks, OPP, clock latency) as well to > >> make it all work. > >> > >> Signed-off-by: Viresh Kumar > > > > Applied both, thanks! > > Please fix the "ARM" prefix when applying. :) Done, thanks for the reminder :) Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: