From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/6] x86/pat: Simplify host PAT handling
Date: Wed, 6 Jun 2018 11:39:46 +0200 [thread overview]
Message-ID: <20180606093946.5pa6w5dvgo4bcpz6@MacBook-Pro-de-Roger.local> (raw)
In-Reply-To: <1527517678-1779-4-git-send-email-andrew.cooper3@citrix.com>
On Mon, May 28, 2018 at 03:27:55PM +0100, Andrew Cooper wrote:
> With the removal of the 32bit hypervisor build, host_pat is a constant value.
> Drop the variable and the redundant cpu_has_pat predicate, and use a define
> instead.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> diff --git a/xen/include/asm-x86/processor.h b/xen/include/asm-x86/processor.h
> index 9924cdf..ac1577c 100644
> --- a/xen/include/asm-x86/processor.h
> +++ b/xen/include/asm-x86/processor.h
> @@ -97,6 +97,12 @@
> X86_EFLAGS_NT|X86_EFLAGS_DF|X86_EFLAGS_IF| \
> X86_EFLAGS_TF)
>
> +/*
> + * Host IA32_CR_PAT value to cover all memory types. This is not the default
> + * MSR_PAT value, and is an ABI with PV guests.
> + */
> +#define XEN_MSR_PAT 0x050100070406ul
Not sure whether it would make sense to use MASK_INSR and define each
page attribute field in order to create this value.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-06-06 9:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 14:27 [PATCH 0/6] x86/vmx: Misc fixes and improvements Andrew Cooper
2018-05-28 14:27 ` [PATCH 1/6] x86/vmx: Fix handing of MSR_DEBUGCTL on VMExit Andrew Cooper
2018-05-29 10:33 ` Jan Beulich
2018-05-29 18:08 ` Andrew Cooper
2018-05-30 7:32 ` Jan Beulich
2018-05-30 10:28 ` Andrew Cooper
2018-05-30 10:49 ` Jan Beulich
2018-05-30 17:34 ` [PATCH v2 " Andrew Cooper
2018-06-01 9:28 ` Jan Beulich
2018-06-05 7:54 ` Tian, Kevin
2018-05-28 14:27 ` [PATCH 2/6] x86: Improvements to ler debugging Andrew Cooper
2018-05-29 11:39 ` Jan Beulich
2018-05-29 18:09 ` Andrew Cooper
2018-06-05 7:55 ` Tian, Kevin
2018-05-28 14:27 ` [PATCH 3/6] x86/pat: Simplify host PAT handling Andrew Cooper
2018-05-29 11:40 ` Jan Beulich
2018-06-06 9:39 ` Roger Pau Monné [this message]
2018-05-28 14:27 ` [PATCH 4/6] x86/vmx: Simplify PAT handling during vcpu construction Andrew Cooper
2018-05-29 11:41 ` Jan Beulich
2018-06-05 7:57 ` Tian, Kevin
2018-06-06 9:42 ` Roger Pau Monné
2018-05-28 14:27 ` [PATCH 5/6] x86/vmx: Defer vmx_vmcs_exit() as long as possible in construct_vmcs() Andrew Cooper
2018-05-29 11:43 ` Jan Beulich
2018-06-05 8:00 ` Tian, Kevin
2018-06-06 9:45 ` Roger Pau Monné
2018-06-06 10:11 ` Andrew Cooper
2018-05-28 14:27 ` [PATCH 6/6] x86/vmx: Drop VMX signal for full real-mode Andrew Cooper
2018-06-05 8:01 ` Tian, Kevin
2018-06-06 10:03 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606093946.5pa6w5dvgo4bcpz6@MacBook-Pro-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.