All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Winiarski" <michal.winiarski@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@ists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/drv_module_reload: Revamp fault-injection
Date: Wed, 6 Jun 2018 16:18:14 +0200	[thread overview]
Message-ID: <20180606141814.vvgbyczvdixzckbd@mwiniars-main.ger.corp.intel.com> (raw)
In-Reply-To: <20180606130916.20716-1-chris@chris-wilson.co.uk>

On Wed, Jun 06, 2018 at 02:09:16PM +0100, Chris Wilson wrote:
> The current method of checking for a failed module load is flawed, as we
> only report the error on probing it is not being reported back by
> modprobe. So we have to dig inside the module_parameters while the
> module is still loaded to discover the error.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>

That also works.

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

Should we push now? Or delay until we fix i915?

-Michał

> ---
>  tests/drv_module_reload.c | 48 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 43 insertions(+), 5 deletions(-)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-06 14:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 13:09 [PATCH i-g-t] igt/drv_module_reload: Revamp fault-injection Chris Wilson
2018-06-06 14:18 ` Michał Winiarski [this message]
2018-06-06 14:30   ` Chris Wilson
2018-06-06 17:42 ` [PATCH i-g-t v2] " Chris Wilson
2018-06-06 17:42   ` [Intel-gfx] " Chris Wilson
2018-06-06 18:00   ` Imre Deak
2018-06-06 18:00     ` [igt-dev] " Imre Deak
2018-06-06 18:04     ` Chris Wilson
2018-06-06 18:04       ` [Intel-gfx] " Chris Wilson
2018-06-06 18:15       ` Imre Deak
2018-06-06 18:15         ` [igt-dev] " Imre Deak
2018-06-06 20:48   ` Antonio Argenziano
2018-06-06 20:48     ` Antonio Argenziano
2018-06-06 20:54     ` Chris Wilson
2018-06-06 20:54       ` Chris Wilson
2018-06-06 18:36 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-06-07 10:49 ` Patchwork
2018-06-07 10:56   ` Chris Wilson
2018-06-07 14:56 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork
2018-06-07 10:58 [PATCH i-g-t] " Chris Wilson
2018-06-07 11:43 ` Chris Wilson
2018-06-27 21:20 Chris Wilson
2018-07-12  8:57 Chris Wilson
2018-07-12  8:59 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180606141814.vvgbyczvdixzckbd@mwiniars-main.ger.corp.intel.com \
    --to=michal.winiarski@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@ists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.