From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Authentication-Results: smtp.codeaurora.org;
	dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UnqGs8/D"
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 70797605BD
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=kernel.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752991AbeFFS7S (ORCPT <rfc822;monsieuricon@codeaurora.org>
        + 25 others); Wed, 6 Jun 2018 14:59:18 -0400
Received: from mail.kernel.org ([198.145.29.99]:41668 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752330AbeFFS7R (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Jun 2018 14:59:17 -0400
Date: Wed, 6 Jun 2018 15:59:14 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>, Jiri Olsa <jolsa@redhat.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH V4 1/3] kallsyms: Simplify update_iter_mod()
Message-ID: <20180606185914.GJ24381@kernel.org>
References: <1528289651-4113-1-git-send-email-adrian.hunter@intel.com>
 <1528289651-4113-2-git-send-email-adrian.hunter@intel.com>
 <20180606131302.GB12180@hirez.programming.kicks-ass.net>
 <20180606143727.03da2e26@vmware.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180606143727.03da2e26@vmware.local.home>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Jun 06, 2018 at 02:37:27PM -0400, Steven Rostedt escreveu:
> On Wed, 6 Jun 2018 15:13:02 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Wed, Jun 06, 2018 at 03:54:09PM +0300, Adrian Hunter wrote:
> > > The logic in update_iter_mod() is overcomplicated and gets worse every time
> > > another get_ksymbol_* function is added.
> > > 
> > > In preparation for adding another get_ksymbol_* function, simplify logic in
> > > update_iter_mod().
> > > 
> > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> > > Acked-by: Andi Kleen <ak@linux.intel.com>  
> > 
> > Both Daniel and Steven touched this function last year, let's also Cc
> > them.
> 
> Thanks for Ccing me. I tested the patch to make sure my changes still
> work and they do:
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Since you said you tested the patch, may I replace the Acked-by with the
stronger Tested-by?

Thanks,

- Arnaldo