Re: [Qemu-devel] [PATCH V6 7/7] migration/ram: ensure write persistence on loading all data to PMEM.

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: junyan.he@gmx.com, qemu-devel@nongnu.org,
	xiaoguangrong.eric@gmail.com, crosthwaite.peter@gmail.com,
	mst@redhat.com, ehabkost@redhat.com, quintela@redhat.com,
	Junyan He <junyan.he@intel.com>,
	stefanha@redhat.com, pbonzini@redhat.com, imammedo@redhat.com,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH V6 7/7] migration/ram: ensure write persistence on loading all data to PMEM.
Date: Thu, 7 Jun 2018 11:42:23 +0100	[thread overview]
Message-ID: <20180607104222.GH2522@work-vm> (raw)
In-Reply-To: <20180605114412.GE11888@stefanha-x1.localdomain>

* Stefan Hajnoczi (stefanha@gmail.com) wrote:
> On Fri, Jun 01, 2018 at 04:10:29PM +0800, junyan.he@gmx.com wrote:
> > diff --git a/migration/ram.c b/migration/ram.c
> > index aa0c6f0..09525b2 100644
> > --- a/migration/ram.c
> > +++ b/migration/ram.c
> > @@ -33,6 +33,7 @@
> >  #include "qemu/bitops.h"
> >  #include "qemu/bitmap.h"
> >  #include "qemu/main-loop.h"
> > +#include "qemu/pmem.h"
> >  #include "xbzrle.h"
> >  #include "ram.h"
> >  #include "migration.h"
> > @@ -3046,6 +3047,13 @@ static int ram_load_setup(QEMUFile *f, void *opaque)
> >  static int ram_load_cleanup(void *opaque)
> >  {
> >      RAMBlock *rb;
> > +
> > +    RAMBLOCK_FOREACH(rb) {
> > +        if (ramblock_is_pmem(rb)) {
> > +            pmem_persist(rb->host, rb->used_length);
> > +         }
> 
> Indentation is off.  This can be fixed by the maintainer who merges
> these patches.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

The other thing that needs a fixup for is RAMBLOCK_FOREACH_MIGRATABLE
that recently got merged.

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK