Hi! > >>> + { "hp4-bluetooth", }, > >>> + {}, > >>> +}; > >>> + > >>> static struct serdev_device_driver nokia_bluetooth_serdev_driver = { > >>> .probe = nokia_bluetooth_serdev_probe, > >>> .remove = nokia_bluetooth_serdev_remove, > >>> @@ -809,6 +814,7 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = { > >>> .pm = &nokia_bluetooth_pm_ops, > >>> .of_match_table = of_match_ptr(nokia_bluetooth_of_match), > >>> }, > >>> + .id_table = nokia_bluetooth_serdev_id, > >>> }; > >> > >> I would actually skip this hardware. First of all it is such a dedicated custom Nokia transport and hardware, and secondly it is no longer produced anyway. > >> > > > > Would it make sense to cc: sre here? We want good support even for old > > hardware, and this is n9/n950, it is still on "top ten supported > > phones" list... Probably even top 5. > > but that is not what this patch series is about. We do not need new_id kinda support for the existing hardware. My point is there will be no newly designed hardware using this driver. > You are right, new hardware with that protocol sounds unlikely at this point. Sorry for the noise, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html