All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Phil Sutter <phil@nwl.cc>, Jakub Sitnicki <jkbs@redhat.com>
Subject: Re: [RFC net-next] ipv4: Don't promote secondaries when flushing addresses
Date: Thu, 7 Jun 2018 15:44:16 +0200	[thread overview]
Message-ID: <20180607134416.qkmjavetihbdk4o6@unicorn.suse.cz> (raw)
In-Reply-To: <20180607123539.GH16785@orbyte.nwl.cc>

On Thu, Jun 07, 2018 at 02:35:39PM +0200, Phil Sutter wrote:
> Yes, I agree with Michal. IIRC, flushing a specific primary along with
> all it's secondaries from an interface is not even supported by
> iproute2, so no need to optimize for that I guess. OTOH, if your
> solution allowed to get rid of that nasty loop in ipaddr_flush(), I owe
> you one extra beer at the next occasion. :)

I'm afraid it will have to stay as fallback for older kernels not
supporting flush requests. But there would be no need to actually use
it. If we know RTM_DELADDR request for zero address is guaranteed to
fail with current and older kernels, we could do

  - use RTM_DELADDR with IFA_F_FLUSH and zero address
  - if it fails, get the list and run the loop

If not, it could still be

  - use RTM_DELADDR with IFA_F_FLUSH and zero address
  - get the list of addresses (empty if first step worked)
  - run the loop

Michal Kubecek

      reply	other threads:[~2018-06-07 13:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 10:13 [RFC net-next] ipv4: Don't promote secondaries when flushing addresses Jakub Sitnicki
2018-06-07 11:00 ` Michal Kubecek
2018-06-07 12:17   ` Jakub Sitnicki
2018-06-07 12:35     ` Phil Sutter
2018-06-07 13:44       ` Michal Kubecek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607134416.qkmjavetihbdk4o6@unicorn.suse.cz \
    --to=mkubecek@suse.cz \
    --cc=jkbs@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.