From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH nvmetcli] ANA configuration support
Date: Thu, 7 Jun 2018 14:38:52 +0200 [thread overview]
Message-ID: <20180607143852.1f0b9f9c@pentland.suse.de> (raw)
In-Reply-To: <20180607121245.GE11938@lst.de>
On Thu, 7 Jun 2018 14:12:45 +0200
Christoph Hellwig <hch@lst.de> wrote:
> On Thu, Jun 07, 2018@12:00:35PM +0200, Johannes Thumshirn wrote:
> > On Thu, Jun 07, 2018 at 11:57:09AM +0200, Hannes Reinecke wrote:
> > > +class ANA_Group(CFSNode):
> >
> > Please use ANAGroup to be consistent with the rest and Python's PEP8
> > guidelines.
>
> Agreed. Please run the code through pep8 and pylint in general.
> There are a few warnings, especially from the latter, but nothing
> crazy should be introduced.
>
> Also we'll need to cover the ANA code in the unit tests.
>
No problem. First time for me to send a substantial python patch, so I
guess I have still a learning curve here.
Cheers,
Hannes
next prev parent reply other threads:[~2018-06-07 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 9:57 [PATCH nvmetcli] ANA configuration support Hannes Reinecke
2018-06-07 10:00 ` Johannes Thumshirn
2018-06-07 12:12 ` Christoph Hellwig
2018-06-07 12:38 ` Hannes Reinecke [this message]
2018-07-27 11:08 [PATCH] nvmetcli: " Hannes Reinecke
2018-10-06 12:43 ` Christoph Hellwig
2018-10-06 13:09 ` Hannes Reinecke
2018-10-17 7:11 ` Christoph Hellwig
2018-11-08 8:48 ` Christoph Hellwig
2018-11-08 8:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607143852.1f0b9f9c@pentland.suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.