From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQwBr-0000np-Gh for qemu-devel@nongnu.org; Thu, 07 Jun 2018 10:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQwBo-00089o-Ew for qemu-devel@nongnu.org; Thu, 07 Jun 2018 10:47:03 -0400 Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Thu, 7 Jun 2018 11:46:41 -0300 Message-Id: <20180607144645.10187-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v2 0/4] qapi/error: converts error_setg(&error_fatal) to error_report() + exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Markus Armbruster Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Peter Maydell , qemu-block@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, John Snow , Kevin Wolf , Max Reitz , David Gibson , Peter Crosthwaite , Alexander Graf Hi, This series converts error_setg(&error_fatal) to error_report() + exit() as suggested by the "qapi/error.h" documentation. This reduce Coverity and Clang static analyzer positive falses. See http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07585.html: On 07/24/2017 04:52 PM, Eric Blake wrote: That's a shame. Rather, we should patch this file (and others) to avoid all the inconsistent uses of error_setg(&error_*), to comply with the error.h documentation. Since v1: - patch #1: use assert() directly (Markus explanation) - patch #2: use abort() without error_report() (Markus 'no lipstick') - patch #3: replaced exit() by assert() (Markus) - patch #4: no change, added R-b Regards, Phil. Philippe Mathieu-Daudé (4): hw/block/fdc: Replace error_setg(&error_abort) by assert() hw/ppc/spapr_drc: Replace error_setg(&error_abort) by abort() hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit() device_tree: Replace error_setg(&error_fatal) by error_report() + exit() device_tree.c | 23 +++++++++++++---------- hw/arm/sysbus-fdt.c | 42 +++++++++++++++++++++++------------------- hw/block/fdc.c | 9 +-------- hw/ppc/spapr_drc.c | 2 +- 4 files changed, 38 insertions(+), 38 deletions(-) -- 2.17.1