From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22B9E21106F0E for ; Thu, 7 Jun 2018 08:30:54 -0700 (PDT) Date: Thu, 7 Jun 2018 18:30:52 +0300 From: "Michael S. Tsirkin" Subject: Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities Message-ID: <20180607182949-mutt-send-email-mst@kernel.org> References: <20180521163203.26590-1-ross.zwisler@linux.intel.com> <20180521163203.26590-4-ross.zwisler@linux.intel.com> <20180605182243-mutt-send-email-mst@kernel.org> <20180605164205.GA21034@linux.intel.com> <20180605213547-mutt-send-email-mst@kernel.org> <20180605220700.GB16066@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Elliott, Robert (Persistent Memory)" Cc: Eduardo Habkost , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov List-ID: On Wed, Jun 06, 2018 at 11:20:58PM +0000, Elliott, Robert (Persistent Memory) wrote: > > > > Okay, we can move to the symbolic names. Do you want them to be that > > long, or > > > would: > > > > > > nvdimm-cap-cpu > > > nvdimm-cap-mem-ctrl > > > nvdimm-cap-mirroring > > > > Wait, why is mirroring part of this? > > This data structure is intended to report any kind of platform capability, not > just platform persistence capabilities. > > We could add a short symbolic name to the definitions in ACPI that matches > the ones selected for this command line option, if that'll help people > find the right names to use. > > I recommend mc rather than mem-ctrl to keep dashes as special. > I'm not sure it's a good idea: dashes aren't special in qemu, and mc's way too brief. -- MST _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQwsL-0001SD-0w for qemu-devel@nongnu.org; Thu, 07 Jun 2018 11:30:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQwsH-0004iW-S8 for qemu-devel@nongnu.org; Thu, 07 Jun 2018 11:30:57 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44600 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQwsH-0004iN-N4 for qemu-devel@nongnu.org; Thu, 07 Jun 2018 11:30:53 -0400 Date: Thu, 7 Jun 2018 18:30:52 +0300 From: "Michael S. Tsirkin" Message-ID: <20180607182949-mutt-send-email-mst@kernel.org> References: <20180521163203.26590-1-ross.zwisler@linux.intel.com> <20180521163203.26590-4-ross.zwisler@linux.intel.com> <20180605182243-mutt-send-email-mst@kernel.org> <20180605164205.GA21034@linux.intel.com> <20180605213547-mutt-send-email-mst@kernel.org> <20180605220700.GB16066@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Elliott, Robert (Persistent Memory)" Cc: 'Dan Williams' , Ross Zwisler , Eduardo Habkost , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov On Wed, Jun 06, 2018 at 11:20:58PM +0000, Elliott, Robert (Persistent Memory) wrote: > > > > Okay, we can move to the symbolic names. Do you want them to be that > > long, or > > > would: > > > > > > nvdimm-cap-cpu > > > nvdimm-cap-mem-ctrl > > > nvdimm-cap-mirroring > > > > Wait, why is mirroring part of this? > > This data structure is intended to report any kind of platform capability, not > just platform persistence capabilities. > > We could add a short symbolic name to the definitions in ACPI that matches > the ones selected for this command line option, if that'll help people > find the right names to use. > > I recommend mc rather than mem-ctrl to keep dashes as special. > I'm not sure it's a good idea: dashes aren't special in qemu, and mc's way too brief. -- MST