Re: [v2 PATCH 0/5] powerpc/pseries: Machien check handler improvements.

From: Nicholas Piggin <npiggin@gmail.com>
To: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Laurent Dufour <ldufour@linux.vnet.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [v2 PATCH 0/5] powerpc/pseries: Machien check handler improvements.
Date: Thu, 7 Jun 2018 20:45:54 +1000	[thread overview]
Message-ID: <20180607204554.05565a56@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <152836568375.29173.3046879842311381046.stgit@jupiter.in.ibm.com>

On Thu, 07 Jun 2018 15:36:25 +0530
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> wrote:

> This patch series includes some improvement to Machine check handler
> for pseries. Patch 1 fixes an issue where machine check handler crashes
> kernel while accessing vmalloc-ed buffer while in nmi context.
> Patch 3 dumps the SLB contents on SLB MCE errors to improve the debugability.
> Patch 4 display's the MCE error details on console.
> 
> Change in V2:
> - patch 4: Display additional info (NIP and task info) in MCE error details.
> - patch 5: Fix endain bug while restoring of r3 in MCE handler.
> 
> ---
> 
> Mahesh Salgaonkar (5):
>       powerpc/pseries: convert rtas_log_buf to linear allocation.
>       powerpc/pseries: Define MCE error event section.
>       powerpc/pseries: Dump and flush SLB contents on SLB MCE errors.
>       powerpc/pseries: Display machine check error details.
>       powerpc/pseries: Fix endainness while restoring of r3 in MCE handler.

These look good, should patch 5 be moved to patch 2 and the first 2
patches marked for stable?

Do you also plan to dump SLB contents for bare metal MCEs?

Thanks,
Nick