From: Jeff King <peff@peff.net>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Martin-Louis Bright <mlbright@gmail.com>,
lars.schneider@autodesk.com, git@vger.kernel.org,
sandals@crustytoothpaste.net, Johannes.Schindelin@gmx.de,
pstodulk@redhat.com, nickh@reactrix.com,
jeremy.wyman@microsoft.com
Subject: Re: [RFC PATCH v1] http: add http.keepRejectedCredentials config
Date: Fri, 8 Jun 2018 01:47:45 -0400 [thread overview]
Message-ID: <20180608054745.GA2893@sigill.intra.peff.net> (raw)
In-Reply-To: <46F82119-D185-4B41-828B-FC92709CFCDA@gmail.com>
On Thu, Jun 07, 2018 at 08:15:16PM -0700, Lars Schneider wrote:
> > In fact, this patch probably should give the user some advice in that
> > regard (either in the documentation, or as a warning when we skip the
> > rejection). If you _do_ have a bogus credential and set the new option,
> > you'd need to reject it manually (you can do it with "git credential
> > reject", but it's probably easier to just unset the option temporarily
> > and re-invoke the original command).
>
> I like the advice idea very much!
>
> How about this?
>
> $ git fetch
> hint: Git has stored invalid credentials.
> hint: Reject them with 'git credential reject' or
> hint: disable the Git config 'http.keepRejectedCredentials'.
> remote: Invalid username or password.
> fatal: Authentication failed for 'https://server.com/myrepo.git/'
>
> I am not really sure about the grammar :-)
It's probably not worth pointing the user at "git credential reject",
since it's not really meant to be friendly to users. In particular, you
have to speak the credential protocol on stdin.
I _think_
echo https://server.com/myrepo.git | git credential reject
might be enough, but I didn't test. Probably better advice is to just
repeat the command. Maybe:
hint: Git kept invalid credentials due to the value of
hint: http.keepRejectedCredentials. If you wish to drop these
hint: credentials and be prompted for new ones, re-run your
hint: command with "git -c http.keepRejectedCredentials=false".
or something?
-Peff
prev parent reply other threads:[~2018-06-08 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 12:26 [RFC PATCH v1] http: add http.keepRejectedCredentials config lars.schneider
2018-06-04 14:47 ` Jeff King
2018-06-04 16:18 ` Martin-Louis Bright
2018-06-04 18:55 ` Jeff King
2018-06-08 3:15 ` Lars Schneider
2018-06-08 5:47 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608054745.GA2893@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jeremy.wyman@microsoft.com \
--cc=lars.schneider@autodesk.com \
--cc=larsxschneider@gmail.com \
--cc=mlbright@gmail.com \
--cc=nickh@reactrix.com \
--cc=pstodulk@redhat.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.