From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore Date: Thu, 7 Jun 2018 23:26:02 -0700 Message-ID: <20180608062602.GK5738@atomide.com> References: <1528374274-26385-1-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1528374274-26385-1-git-send-email-geert+renesas@glider.be> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: Keerthy , Linus Walleij , linux-gpio@vger.kernel.org, Haojian Zhuang , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org * Geert Uytterhoeven [180607 13:40]: > The divisions (and multiplications) can be avoided by changing the loops > to use increments of mux_bytes instead of 1. > While at it, remove the unneeded casts when assigning void pointers. > > This saves +100 bytes of kernel size on arm32/arm64. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. Makes sense to me: Acked-by: Tony Lindgren Keerthy can you please test? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 7 Jun 2018 23:26:02 -0700 Subject: [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore In-Reply-To: <1528374274-26385-1-git-send-email-geert+renesas@glider.be> References: <1528374274-26385-1-git-send-email-geert+renesas@glider.be> Message-ID: <20180608062602.GK5738@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Geert Uytterhoeven [180607 13:40]: > The divisions (and multiplications) can be avoided by changing the loops > to use increments of mux_bytes instead of 1. > While at it, remove the unneeded casts when assigning void pointers. > > This saves +100 bytes of kernel size on arm32/arm64. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. Makes sense to me: Acked-by: Tony Lindgren Keerthy can you please test? Regards, Tony