From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Vecera Subject: [PATCH ethtool 6/6] ethtool: remove unreachable code Date: Fri, 8 Jun 2018 11:20:10 +0200 Message-ID: <20180608092010.13041-6-cera@cera.cz> References: <20180608092010.13041-1-cera@cera.cz> Cc: netdev@vger.kernel.org, Vidya Sagar Ravipati To: linville@tuxdriver.com Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54922 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751224AbeFHJUU (ORCPT ); Fri, 8 Jun 2018 05:20:20 -0400 In-Reply-To: <20180608092010.13041-1-cera@cera.cz> Sender: netdev-owner@vger.kernel.org List-ID: The default switch case is unreachable as the MAX_CHANNEL_NUM == 4. Fixes: a5e73bb ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support") Cc: Vidya Sagar Ravipati Signed-off-by: Ivan Vecera --- qsfp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/qsfp.c b/qsfp.c index aecd5bb..32e195d 100644 --- a/qsfp.c +++ b/qsfp.c @@ -661,9 +661,6 @@ static void sff8636_dom_parse(const __u8 *id, struct sff_diags *sd) tx_power_offset = SFF8636_TX_PWR_4_OFFSET; tx_bias_offset = SFF8636_TX_BIAS_4_OFFSET; break; - default: - printf(" Invalid channel: %d\n", i); - break; } sd->scd[i].bias_cur = OFFSET_TO_U16(tx_bias_offset); sd->scd[i].rx_power = OFFSET_TO_U16(rx_power_offset); -- 2.16.4