From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fREJy-0002ql-PK for mharc-grub-devel@gnu.org; Fri, 08 Jun 2018 06:08:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fREJw-0002qc-VV for grub-devel@gnu.org; Fri, 08 Jun 2018 06:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fREJt-00009R-JC for grub-devel@gnu.org; Fri, 08 Jun 2018 06:08:36 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:64063 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fREJt-0008VP-7o for grub-devel@gnu.org; Fri, 08 Jun 2018 06:08:33 -0400 X-IronPort-AV: E=Sophos;i="5.49,490,1520899200"; d="scan'208";a="74349680" Date: Fri, 8 Jun 2018 12:08:22 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Daniel Kiper CC: , Subject: Re: [PATCH v2] multiboot2: clarify usage of the address tag Message-ID: <20180608100822.ignnluc6ampugw6z@mac> References: <20180607155906.14304-1-roger.pau@citrix.com> <20180608093552.GA20016@olila.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180608093552.GA20016@olila.local.net-space.pl> User-Agent: NeoMutt/20180512 X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 185.25.65.24 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 10:08:37 -0000 On Fri, Jun 08, 2018 at 11:35:52AM +0200, Daniel Kiper wrote: > On Thu, Jun 07, 2018 at 05:59:06PM +0200, Roger Pau Monne wrote: > > Add a note to spell out that if the address tag is not present the > > file should be loaded using the elf header. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Daniel Kiper > > Cc: xen-devel@lists.xenproject.org > > --- > > Changes since v1: > > - s/elf/@sc{elf}/ > > - s/Multiboot/Multiboot2/ > > --- > > doc/multiboot.texi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > > index 2e2d7e74a..3c797787c 100644 > > --- a/doc/multiboot.texi > > +++ b/doc/multiboot.texi > > @@ -509,6 +509,12 @@ assumes that no bss segment is present. > > > > @end table > > > > +Note: This information does not need to be provided if the kernel image > > +is in @sc{elf} format, but it must be provided if the image is in a.out > > +format or in some other format. Compliant boot loaders must be able to > > +load images that are either in @sc{elf} format or contain the address > > +tag embedded in the Multiboot2 header. > > + > > Now it is better. However, there is a lack of information that this tag > should be preferred over the relevant data provided in the ELF header if > both are available in the image. This have to be clear like it is in > Multiboot spec. Would you be OK with adding the following sentence at the end: "When the address tag is present it must be used in order to load the image, regardless of whether an @sc{elf} header is also present." Roger.