All of lore.kernel.org
 help / color / mirror / Atom feed
* [v3] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk
@ 2018-06-11  7:08 Greg Kroah-Hartman
  0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-06-11  7:08 UTC (permalink / raw)
  To: Mark Knibbs; +Cc: linux-usb, Alan Stern

On Sun, Jun 10, 2018 at 08:54:09PM +0200, Mark Knibbs wrote:
> When I re-sent the patch with tabs I accidentally left the new maximum
> bcdDevice at 0x00ff. Sorry! Hopefully this is finally OK.

This should not be in the change log text, please remove it.

> 
> 
> The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
> was only applied for bcdDevice 0x0009, but later firmware which reports
> bcdDevice 0x0022 needs it too.
> 
> Signed-off-by: Mark Knibbs <mark_k@iname.com>
> ---
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 747d3a9..dfcceaf 100644

Below the --- line you should put what changed for each version of the
patch, so we have an idea of what to look for when reviewing it.

> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1044,7 +1044,7 @@ UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
>  		USB_SC_SCSI, USB_PR_CB, NULL,
>  		US_FL_SINGLE_LUN ),

Tabs all worked fine here.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [v3] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk
@ 2018-06-13 13:08 Mark Knibbs
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Knibbs @ 2018-06-13 13:08 UTC (permalink / raw)
  To: linux-usb; +Cc: Alan Stern, Greg KH

The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
was only applied for bcdDevice 0x0009, but later firmware which reports
bcdDevice 0x0022 needs it too.

Signed-off-by: Mark Knibbs <mark_k@iname.com>
---
v4: Max. bcdDevice is 0x0022 again, removed extraneous text
v3: Fixed tabs, but accidentally reverted max. bcdDevice to 0x00FF
v2: Changed maximum bcdDevice to 0x0022

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 747d3a9..dfcceaf 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1044,7 +1044,7 @@ UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
 		USB_SC_SCSI, USB_PR_CB, NULL,
 		US_FL_SINGLE_LUN ),
 
-UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009,
+UNUSUAL_DEV(  0x0781, 0x0002, 0x0000, 0x0022,
 		"SanDisk Corporation",
 		"ImageMate CompactFlash USB",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [v3] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk
@ 2018-06-10 18:54 Mark Knibbs
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Knibbs @ 2018-06-10 18:54 UTC (permalink / raw)
  To: linux-usb; +Cc: Greg KH, Alan Stern

When I re-sent the patch with tabs I accidentally left the new maximum
bcdDevice at 0x00ff. Sorry! Hopefully this is finally OK.


The SanDisk SDDR-31 needs the US_FL_FIX_CAPACITY quirk. Previously that
was only applied for bcdDevice 0x0009, but later firmware which reports
bcdDevice 0x0022 needs it too.

Signed-off-by: Mark Knibbs <mark_k@iname.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 747d3a9..dfcceaf 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1044,7 +1044,7 @@ UNUSUAL_DEV(  0x0781, 0x0001, 0x0200, 0x0200,
 		USB_SC_SCSI, USB_PR_CB, NULL,
 		US_FL_SINGLE_LUN ),
 
-UNUSUAL_DEV(  0x0781, 0x0002, 0x0009, 0x0009,
+UNUSUAL_DEV(  0x0781, 0x0002, 0x0000, 0x0022,
 		"SanDisk Corporation",
 		"ImageMate CompactFlash USB",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-13 13:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-11  7:08 [v3] storage: Widen bcdDevice range for SanDisk SDDR-31 quirk Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2018-06-13 13:08 Mark Knibbs
2018-06-10 18:54 Mark Knibbs

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.