From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 11 Jun 2018 14:44:05 +0300 From: Heikki Krogerus Subject: Re: [PATCH v6 04/15] usb: typec: add fwnode to tcpc Message-ID: <20180611114405.GH17155@kuha.fi.intel.com> References: <1527475967-15201-1-git-send-email-jun.li@nxp.com> <1527475967-15201-5-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527475967-15201-5-git-send-email-jun.li@nxp.com> To: Li Jun Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, cw00.choi@samsung.com, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, garsilva@embeddedor.com, gsomlo@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com List-ID: On Mon, May 28, 2018 at 10:52:36AM +0800, Li Jun wrote: > Add fwnode handle to get the fwnode so we can get typec configs > it contains. > > Suggested-by: Heikki Krogerus > Signed-off-by: Li Jun Reviewed-by: Heikki Krogerus > --- > drivers/staging/typec/tcpci.c | 7 +++++++ > drivers/usb/typec/tcpm.c | 1 + > include/linux/usb/tcpm.h | 2 ++ > 3 files changed, 10 insertions(+) > > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c > index dd29288..e59547a 100644 > --- a/drivers/staging/typec/tcpci.c > +++ b/drivers/staging/typec/tcpci.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -474,6 +475,12 @@ static int tcpci_parse_config(struct tcpci *tcpci) > > /* TODO: Populate struct tcpc_config from ACPI/device-tree */ > tcpci->tcpc.config = &tcpci_tcpc_config; > + tcpci->tcpc.fwnode = device_get_named_child_node(tcpci->dev, > + "connector"); > + if (!tcpci->tcpc.fwnode) { > + dev_err(tcpci->dev, "Can't find connector node.\n"); > + return -EINVAL; > + } > > return 0; > } > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 0ccd2ce..fcd22e8 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -4581,6 +4581,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) > else > port->try_role = TYPEC_NO_PREFERRED_ROLE; > > + port->typec_caps.fwnode = tcpc->fwnode; > port->typec_caps.prefer_role = tcpc->config->default_role; > port->typec_caps.type = tcpc->config->type; > port->typec_caps.data = tcpc->config->data; > diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h > index b231b93..193920a 100644 > --- a/include/linux/usb/tcpm.h > +++ b/include/linux/usb/tcpm.h > @@ -110,6 +110,7 @@ enum tcpc_mux_mode { > /** > * struct tcpc_dev - Port configuration and callback functions > * @config: Pointer to port configuration > + * @fwnode: Pointer to port fwnode > * @get_vbus: Called to read current VBUS state > * @get_current_limit: > * Optional; called by the tcpm core when configured as a snk > @@ -138,6 +139,7 @@ enum tcpc_mux_mode { > */ > struct tcpc_dev { > const struct tcpc_config *config; > + struct fwnode_handle *fwnode; > > int (*init)(struct tcpc_dev *dev); > int (*get_vbus)(struct tcpc_dev *dev); > -- > 2.7.4 -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v6,04/15] usb: typec: add fwnode to tcpc From: Heikki Krogerus Message-Id: <20180611114405.GH17155@kuha.fi.intel.com> Date: Mon, 11 Jun 2018 14:44:05 +0300 To: Li Jun Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, cw00.choi@samsung.com, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, garsilva@embeddedor.com, gsomlo@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com List-ID: T24gTW9uLCBNYXkgMjgsIDIwMTggYXQgMTA6NTI6MzZBTSArMDgwMCwgTGkgSnVuIHdyb3RlOgo+ IEFkZCBmd25vZGUgaGFuZGxlIHRvIGdldCB0aGUgZndub2RlIHNvIHdlIGNhbiBnZXQgdHlwZWMg Y29uZmlncwo+IGl0IGNvbnRhaW5zLgo+IAo+IFN1Z2dlc3RlZC1ieTogSGVpa2tpIEtyb2dlcnVz IDxoZWlra2kua3JvZ2VydXNAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IExpIEp1 biA8anVuLmxpQG54cC5jb20+CgpSZXZpZXdlZC1ieTogSGVpa2tpIEtyb2dlcnVzIDxoZWlra2ku a3JvZ2VydXNAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9zdGFnaW5nL3R5cGVj L3RjcGNpLmMgfCA3ICsrKysrKysKPiAgZHJpdmVycy91c2IvdHlwZWMvdGNwbS5jICAgICAgfCAx ICsKPiAgaW5jbHVkZS9saW51eC91c2IvdGNwbS5oICAgICAgfCAyICsrCj4gIDMgZmlsZXMgY2hh bmdlZCwgMTAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcv dHlwZWMvdGNwY2kuYyBiL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jCj4gaW5kZXggZGQy OTI4OC4uZTU5NTQ3YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvdHlwZWMvdGNwY2ku Ywo+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jCj4gQEAgLTEwLDYgKzEwLDcg QEAKPiAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvaTJjLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1cHQuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3Byb3Bl cnR5Lmg+Cj4gICNpbmNsdWRlIDxsaW51eC9yZWdtYXAuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3Vz Yi9wZC5oPgo+ICAjaW5jbHVkZSA8bGludXgvdXNiL3RjcG0uaD4KPiBAQCAtNDc0LDYgKzQ3NSwx MiBAQCBzdGF0aWMgaW50IHRjcGNpX3BhcnNlX2NvbmZpZyhzdHJ1Y3QgdGNwY2kgKnRjcGNpKQo+ ICAKPiAgCS8qIFRPRE86IFBvcHVsYXRlIHN0cnVjdCB0Y3BjX2NvbmZpZyBmcm9tIEFDUEkvZGV2 aWNlLXRyZWUgKi8KPiAgCXRjcGNpLT50Y3BjLmNvbmZpZyA9ICZ0Y3BjaV90Y3BjX2NvbmZpZzsK PiArCXRjcGNpLT50Y3BjLmZ3bm9kZSA9IGRldmljZV9nZXRfbmFtZWRfY2hpbGRfbm9kZSh0Y3Bj aS0+ZGV2LAo+ICsJCQkJCQkJICJjb25uZWN0b3IiKTsKPiArCWlmICghdGNwY2ktPnRjcGMuZndu b2RlKSB7Cj4gKwkJZGV2X2Vycih0Y3BjaS0+ZGV2LCAiQ2FuJ3QgZmluZCBjb25uZWN0b3Igbm9k ZS5cbiIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICAKPiAgCXJldHVybiAwOwo+ICB9 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3R5cGVjL3RjcG0uYyBiL2RyaXZlcnMvdXNiL3R5 cGVjL3RjcG0uYwo+IGluZGV4IDBjY2QyY2UuLmZjZDIyZTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy91c2IvdHlwZWMvdGNwbS5jCj4gKysrIGIvZHJpdmVycy91c2IvdHlwZWMvdGNwbS5jCj4gQEAg LTQ1ODEsNiArNDU4MSw3IEBAIHN0cnVjdCB0Y3BtX3BvcnQgKnRjcG1fcmVnaXN0ZXJfcG9ydChz dHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCB0Y3BjX2RldiAqdGNwYykKPiAgCWVsc2UKPiAgCQlw b3J0LT50cnlfcm9sZSA9IFRZUEVDX05PX1BSRUZFUlJFRF9ST0xFOwo+ICAKPiArCXBvcnQtPnR5 cGVjX2NhcHMuZndub2RlID0gdGNwYy0+Zndub2RlOwo+ICAJcG9ydC0+dHlwZWNfY2Fwcy5wcmVm ZXJfcm9sZSA9IHRjcGMtPmNvbmZpZy0+ZGVmYXVsdF9yb2xlOwo+ICAJcG9ydC0+dHlwZWNfY2Fw cy50eXBlID0gdGNwYy0+Y29uZmlnLT50eXBlOwo+ICAJcG9ydC0+dHlwZWNfY2Fwcy5kYXRhID0g dGNwYy0+Y29uZmlnLT5kYXRhOwo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3VzYi90Y3Bt LmggYi9pbmNsdWRlL2xpbnV4L3VzYi90Y3BtLmgKPiBpbmRleCBiMjMxYjkzLi4xOTM5MjBhIDEw MDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvdXNiL3RjcG0uaAo+ICsrKyBiL2luY2x1ZGUvbGlu dXgvdXNiL3RjcG0uaAo+IEBAIC0xMTAsNiArMTEwLDcgQEAgZW51bSB0Y3BjX211eF9tb2RlIHsK PiAgLyoqCj4gICAqIHN0cnVjdCB0Y3BjX2RldiAtIFBvcnQgY29uZmlndXJhdGlvbiBhbmQgY2Fs bGJhY2sgZnVuY3Rpb25zCj4gICAqIEBjb25maWc6CVBvaW50ZXIgdG8gcG9ydCBjb25maWd1cmF0 aW9uCj4gKyAqIEBmd25vZGU6CVBvaW50ZXIgdG8gcG9ydCBmd25vZGUKPiAgICogQGdldF92YnVz OglDYWxsZWQgdG8gcmVhZCBjdXJyZW50IFZCVVMgc3RhdGUKPiAgICogQGdldF9jdXJyZW50X2xp bWl0Ogo+ICAgKgkJT3B0aW9uYWw7IGNhbGxlZCBieSB0aGUgdGNwbSBjb3JlIHdoZW4gY29uZmln dXJlZCBhcyBhIHNuawo+IEBAIC0xMzgsNiArMTM5LDcgQEAgZW51bSB0Y3BjX211eF9tb2RlIHsK PiAgICovCj4gIHN0cnVjdCB0Y3BjX2RldiB7Cj4gIAljb25zdCBzdHJ1Y3QgdGNwY19jb25maWcg KmNvbmZpZzsKPiArCXN0cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGU7Cj4gIAo+ICAJaW50ICgq aW5pdCkoc3RydWN0IHRjcGNfZGV2ICpkZXYpOwo+ICAJaW50ICgqZ2V0X3ZidXMpKHN0cnVjdCB0 Y3BjX2RldiAqZGV2KTsKPiAtLSAKPiAyLjcuNAo=