From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 11 Jun 2018 15:33:35 +0300 From: Heikki Krogerus Subject: Re: [PATCH v6 07/15] staging: typec: tcpci: remove unused tcpci_tcpc_config Message-ID: <20180611123335.GM17155@kuha.fi.intel.com> References: <1527475967-15201-1-git-send-email-jun.li@nxp.com> <1527475967-15201-8-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527475967-15201-8-git-send-email-jun.li@nxp.com> To: Li Jun Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, cw00.choi@samsung.com, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, garsilva@embeddedor.com, gsomlo@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com List-ID: On Mon, May 28, 2018 at 10:52:39AM +0800, Li Jun wrote: > Since we will use config settings via device properties, so > remove the hard code tcpci_tcpc_config. > > Signed-off-by: Li Jun FWIW: Reviewed-by: Heikki Krogerus > --- > drivers/staging/typec/tcpci.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c > index e59547a..076498a 100644 > --- a/drivers/staging/typec/tcpci.c > +++ b/drivers/staging/typec/tcpci.c > @@ -464,17 +464,10 @@ static const struct regmap_config tcpci_regmap_config = { > .max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */ > }; > > -static const struct tcpc_config tcpci_tcpc_config = { > - .type = TYPEC_PORT_DFP, > - .default_role = TYPEC_SINK, > -}; > - > static int tcpci_parse_config(struct tcpci *tcpci) > { > tcpci->controls_vbus = true; /* XXX */ > > - /* TODO: Populate struct tcpc_config from ACPI/device-tree */ > - tcpci->tcpc.config = &tcpci_tcpc_config; > tcpci->tcpc.fwnode = device_get_named_child_node(tcpci->dev, > "connector"); > if (!tcpci->tcpc.fwnode) { > -- > 2.7.4 -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v6,07/15] staging: typec: tcpci: remove unused tcpci_tcpc_config From: Heikki Krogerus Message-Id: <20180611123335.GM17155@kuha.fi.intel.com> Date: Mon, 11 Jun 2018 15:33:35 +0300 To: Li Jun Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, cw00.choi@samsung.com, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, garsilva@embeddedor.com, gsomlo@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com List-ID: T24gTW9uLCBNYXkgMjgsIDIwMTggYXQgMTA6NTI6MzlBTSArMDgwMCwgTGkgSnVuIHdyb3RlOgo+ IFNpbmNlIHdlIHdpbGwgdXNlIGNvbmZpZyBzZXR0aW5ncyB2aWEgZGV2aWNlIHByb3BlcnRpZXMs IHNvCj4gcmVtb3ZlIHRoZSBoYXJkIGNvZGUgdGNwY2lfdGNwY19jb25maWcuCj4gCj4gU2lnbmVk LW9mZi1ieTogTGkgSnVuIDxqdW4ubGlAbnhwLmNvbT4KCkZXSVc6CgpSZXZpZXdlZC1ieTogSGVp a2tpIEtyb2dlcnVzIDxoZWlra2kua3JvZ2VydXNAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAg ZHJpdmVycy9zdGFnaW5nL3R5cGVjL3RjcGNpLmMgfCA3IC0tLS0tLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy90eXBl Yy90Y3BjaS5jIGIvZHJpdmVycy9zdGFnaW5nL3R5cGVjL3RjcGNpLmMKPiBpbmRleCBlNTk1NDdh Li4wNzY0OThhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jCj4g KysrIGIvZHJpdmVycy9zdGFnaW5nL3R5cGVjL3RjcGNpLmMKPiBAQCAtNDY0LDE3ICs0NjQsMTAg QEAgc3RhdGljIGNvbnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIHRjcGNpX3JlZ21hcF9jb25maWcg PSB7Cj4gIAkubWF4X3JlZ2lzdGVyID0gMHg3RiwgLyogMHg4MCAuLiAweEZGIGFyZSB2ZW5kb3Ig ZGVmaW5lZCAqLwo+ICB9Owo+ICAKPiAtc3RhdGljIGNvbnN0IHN0cnVjdCB0Y3BjX2NvbmZpZyB0 Y3BjaV90Y3BjX2NvbmZpZyA9IHsKPiAtCS50eXBlID0gVFlQRUNfUE9SVF9ERlAsCj4gLQkuZGVm YXVsdF9yb2xlID0gVFlQRUNfU0lOSywKPiAtfTsKPiAtCj4gIHN0YXRpYyBpbnQgdGNwY2lfcGFy c2VfY29uZmlnKHN0cnVjdCB0Y3BjaSAqdGNwY2kpCj4gIHsKPiAgCXRjcGNpLT5jb250cm9sc192 YnVzID0gdHJ1ZTsgLyogWFhYICovCj4gIAo+IC0JLyogVE9ETzogUG9wdWxhdGUgc3RydWN0IHRj cGNfY29uZmlnIGZyb20gQUNQSS9kZXZpY2UtdHJlZSAqLwo+IC0JdGNwY2ktPnRjcGMuY29uZmln ID0gJnRjcGNpX3RjcGNfY29uZmlnOwo+ICAJdGNwY2ktPnRjcGMuZndub2RlID0gZGV2aWNlX2dl dF9uYW1lZF9jaGlsZF9ub2RlKHRjcGNpLT5kZXYsCj4gIAkJCQkJCQkgImNvbm5lY3RvciIpOwo+ ICAJaWYgKCF0Y3BjaS0+dGNwYy5md25vZGUpIHsKPiAtLSAKPiAyLjcuNAo=