From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation
Date: Mon, 11 Jun 2018 19:51:01 +0300 [thread overview]
Message-ID: <20180611165101.GZ23723@intel.com> (raw)
In-Reply-To: <4345236.ACRzYZSY9C@avalon>
On Thu, Jun 07, 2018 at 03:13:23PM +0300, Laurent Pinchart wrote:
> Hi Ville,
>
> On Thursday, 7 June 2018 15:03:12 EEST Ville Syrjälä wrote:
> > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote:
> > > The drm_connector_helper_funcs .mode_valid() operation should not modify
> > > the mode it receives in any way. To make this explicit, constify the
> > > mode pointer as done for all other .mode_valid() operations, and update
> > > all drivers accordingly.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Didn't spot anything wrong. I think the omap case should be fine as
> > well since the probe helper will populate the vrefresh for the mode
> > eventually.
> >
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The patch has lived in my public tree for a few days now and the kbuild bot
> hasn't complained (or rather it complained on the previous version that I
> hadn't posted to the list yet, and I've fixed the problems before posting this
> version). Given the risk of conflicts I'd rather get this merged sooner than
> later. Is that fine with you ?
Seems safe to me. So IMO just push if no one has complained.
>
> > > ---
> > >
> > > This patch touches lots of drivers, so checkpatch.pl created a huge CC
> > > list that would likely be too large for the mailing list. As changes to
> > > most files just boil down to adding a const keyword, I've decided to only
> > > CC the DRM misc maintainers, as well as Tomi for omapdrm as the change to
> > > that driver is slightly more complex.
> > >
> > > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8 ++++----
> > > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/atombios_dp.h | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
> > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
> > > drivers/gpu/drm/ast/ast_mode.c | 2 +-
> > > drivers/gpu/drm/bochs/bochs_kms.c | 2 +-
> > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++--
> > > drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 2 +-
> > > drivers/gpu/drm/bridge/sii902x.c | 2 +-
> > > drivers/gpu/drm/bridge/tc358767.c | 2 +-
> > > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 2 +-
> > > drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 +-
> > > drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
> > > drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 +-
> > > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +-
> > > drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +-
> > > drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +-
> > > drivers/gpu/drm/gma500/psb_intel_drv.h | 2 +-
> > > drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +-
> > > drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 +-
> > > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 +-
> > > drivers/gpu/drm/i2c/ch7006_drv.c | 2 +-
> > > drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
> > > drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
> > > drivers/gpu/drm/i915/dvo.h | 2 +-
> > > drivers/gpu/drm/i915/dvo_ch7017.c | 2 +-
> > > drivers/gpu/drm/i915/dvo_ch7xxx.c | 2 +-
> > > drivers/gpu/drm/i915/dvo_ivch.c | 2 +-
> > > drivers/gpu/drm/i915/dvo_ns2501.c | 2 +-
> > > drivers/gpu/drm/i915/dvo_sil164.c | 2 +-
> > > drivers/gpu/drm/i915/dvo_tfp410.c | 2 +-
> > > drivers/gpu/drm/i915/intel_crt.c | 2 +-
> > > drivers/gpu/drm/i915/intel_dp.c | 2 +-
> > > drivers/gpu/drm/i915/intel_dp_mst.c | 2 +-
> > > drivers/gpu/drm/i915/intel_dsi.c | 2 +-
> > > drivers/gpu/drm/i915/intel_dvo.c | 2 +-
> > > drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> > > drivers/gpu/drm/i915/intel_lvds.c | 2 +-
> > > drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
> > > drivers/gpu/drm/i915/intel_tv.c | 2 +-
> > > drivers/gpu/drm/imx/imx-tve.c | 2 +-
> > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +-
> > > drivers/gpu/drm/meson/meson_venc_cvbs.c | 2 +-
> > > drivers/gpu/drm/mgag200/mgag200_mode.c | 4 ++--
> > > drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 2 +-
> > > drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +-
> > > drivers/gpu/drm/msm/edp/edp_connector.c | 2 +-
> > > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +-
> > > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 +-
> > > drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
> > > drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
> > > drivers/gpu/drm/omapdrm/omap_connector.c | 7 ++++---
> > > drivers/gpu/drm/qxl/qxl_display.c | 2 +-
> > > drivers/gpu/drm/radeon/atombios_dp.c | 2 +-
> > > drivers/gpu/drm/radeon/radeon_connectors.c | 10 +++++-----
> > > drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +-
> > > drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
> > > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> > > drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
> > > drivers/gpu/drm/sti/sti_dvo.c | 2 +-
> > > drivers/gpu/drm/sti/sti_hda.c | 2 +-
> > > drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> > > drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
> > > drivers/gpu/drm/tegra/dsi.c | 2 +-
> > > drivers/gpu/drm/tegra/hdmi.c | 2 +-
> > > drivers/gpu/drm/tegra/rgb.c | 2 +-
> > > drivers/gpu/drm/tegra/sor.c | 2 +-
> > > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
> > > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 3 ++-
> > > drivers/gpu/drm/tilcdc/tilcdc_external.c | 2 +-
> > > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
> > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 2 +-
> > > drivers/gpu/drm/udl/udl_connector.c | 2 +-
> > > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
> > > drivers/gpu/drm/zte/zx_hdmi.c | 2 +-
> > > drivers/gpu/drm/zte/zx_tvenc.c | 4 ++--
> > > drivers/gpu/drm/zte/zx_vga.c | 2 +-
> > > drivers/staging/vboxvideo/vbox_mode.c | 2 +-
> > > include/drm/drm_encoder_slave.h | 2 +-
> > > include/drm/drm_modeset_helper_vtables.h | 2 +-
> > > 83 files changed, 98 insertions(+), 95 deletions(-)
>
> [snip]
>
> --
> Regards,
>
> Laurent Pinchart
>
>
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-11 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 9:08 [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation Laurent Pinchart
2018-06-07 12:03 ` Ville Syrjälä
2018-06-07 12:09 ` Tomi Valkeinen
2018-06-07 12:13 ` Laurent Pinchart
2018-06-11 16:51 ` Ville Syrjälä [this message]
2018-06-18 8:43 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611165101.GZ23723@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.