From: kbuild test robot <lkp@intel.com>
To: Tejaswi Tanikella <tejaswit@codeaurora.org>
Cc: kbuild-all@01.org, netdev@vger.kernel.org, f.fainelli@gmail.com,
andrew@lunn.ch, davem@davemloft.net
Subject: Re: [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports
Date: Mon, 11 Jun 2018 21:25:48 +0800 [thread overview]
Message-ID: <201806112055.FtkxdgP0%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180611115058.GA12452@tejaswit-linux.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]
Hi Tejaswi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
url: https://github.com/0day-ci/linux/commits/Tejaswi-Tanikella/ipv4-igmp-use-alarmtimer-to-prevent-delayed-reports/20180611-195615
config: i386-randconfig-x012-201823 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: the linux-review/Tejaswi-Tanikella/ipv4-igmp-use-alarmtimer-to-prevent-delayed-reports/20180611-195615 HEAD 20987eecc3144eb22578baea09ff017ddcb45163 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
net//ipv4/igmp.c: In function 'igmp_start_timer':
>> net//ipv4/igmp.c:213:19: error: implicit declaration of function 'jiffies_to_ktime'; did you mean 'jiffies_to_timeval'? [-Werror=implicit-function-declaration]
ktime_t expiry = jiffies_to_ktime(prandom_u32() % max_delay + 2);
^~~~~~~~~~~~~~~~
jiffies_to_timeval
net//ipv4/igmp.c: In function 'igmp_mod_timer':
net//ipv4/igmp.c:250:7: error: implicit declaration of function 'ktime_to_jiffies'; did you mean 'timeval_to_jiffies'? [-Werror=implicit-function-declaration]
if (ktime_to_jiffies(expiry) < max_delay) {
^~~~~~~~~~~~~~~~
timeval_to_jiffies
cc1: some warnings being treated as errors
vim +213 net//ipv4/igmp.c
209
210 /* It must be called with locked im->lock */
211 static void igmp_start_timer(struct ip_mc_list *im, int max_delay)
212 {
> 213 ktime_t expiry = jiffies_to_ktime(prandom_u32() % max_delay + 2);
214
215 im->tm_running = 1;
216 alarm_start_relative(&im->alarm, expiry);
217 refcount_inc(&im->refcnt);
218 }
219
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33045 bytes --]
next prev parent reply other threads:[~2018-06-11 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 11:51 [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports Tejaswi Tanikella
2018-06-11 11:52 ` [PATCH 2/2] ktime: helpers to convert between ktime and jiffies Tejaswi Tanikella
2018-06-12 16:30 ` Andrew Lunn
2018-06-13 13:35 ` Tejaswi Tanikella
2018-06-13 16:51 ` Florian Fainelli
2018-06-11 13:25 ` [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports kbuild test robot
2018-06-11 13:25 ` kbuild test robot [this message]
2018-06-12 16:28 ` Andrew Lunn
2018-06-13 13:32 ` Tejaswi Tanikella
2018-06-13 14:44 ` Andrew Lunn
2018-06-14 13:14 ` Tejaswi Tanikella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201806112055.FtkxdgP0%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=tejaswit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.