From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 11 Jun 2018 20:55:37 -0000 Received: from aserp2120.oracle.com ([141.146.126.78]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fSTqi-0003KQ-48 for speck@linutronix.de; Mon, 11 Jun 2018 22:55:36 +0200 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5BKpNM2066221 for ; Mon, 11 Jun 2018 20:55:29 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2jgecxedv3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Jun 2018 20:55:29 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5BKtSd7010824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Jun 2018 20:55:28 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w5BKtSUu007770 for ; Mon, 11 Jun 2018 20:55:28 GMT Date: Mon, 11 Jun 2018 16:55:26 -0400 From: Konrad Rzeszutek Wilk Subject: [MODERATED] Re: [patch V2 03/12] cpu/hotplug: Make bringup/teardown of smp threads symmetric Message-ID: <20180611205526.GC25607@char.us.oracle.com> References: <20180606192714.754943543@linutronix.de> <20180606192807.178964442@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20180606192807.178964442@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Wed, Jun 06, 2018 at 09:27:17PM +0200, speck for Thomas Gleixner wrote: > Subject: [patch V2 03/12] cpu/hotplug: Make bringup/teardown of smp threads symmetric > From: Thomas Gleixner > > The asymetry caused a warning to trigger if the bootup was stopped in state ^- two 'm's > CPUHP_AP_ONLINE_IDLE. The warning no longer triggers as kthread_park() can > now be invoked on already or still parked threads. But there is still no > reason to have this asymetric. s/asymetric/be asymmetric/ > > Signed-off-by: Thomas Gleixner > --- > kernel/cpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -754,7 +754,6 @@ static int takedown_cpu(unsigned int cpu > > /* Park the smpboot threads */ > kthread_park(per_cpu_ptr(&cpuhp_state, cpu)->thread); > - smpboot_park_threads(cpu); > > /* > * Prevent irq alloc/free while the dying cpu reorganizes the > @@ -1332,7 +1331,7 @@ static struct cpuhp_step cpuhp_hp_states > [CPUHP_AP_SMPBOOT_THREADS] = { > .name = "smpboot/threads:online", > .startup.single = smpboot_unpark_threads, > - .teardown.single = NULL, > + .teardown.single = smpboot_park_threads, > }, > [CPUHP_AP_IRQ_AFFINITY_ONLINE] = { > .name = "irq/affinity:online", >