From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 11 Jun 2018 21:24:29 -0000 Received: from userp2120.oracle.com ([156.151.31.85]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fSUIe-0003fw-2I for speck@linutronix.de; Mon, 11 Jun 2018 23:24:29 +0200 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5BLKvFd042738 for ; Mon, 11 Jun 2018 21:24:21 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2jg7hwy81t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Jun 2018 21:24:21 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5BLOL0s001544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Jun 2018 21:24:21 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w5BLOL85027851 for ; Mon, 11 Jun 2018 21:24:21 GMT Date: Mon, 11 Jun 2018 17:24:20 -0400 From: Konrad Rzeszutek Wilk Subject: [MODERATED] Re: [patch V2 07/12] x86/cpu/AMD: Remove the pointless detect_ht() call Message-ID: <20180611212420.GG25607@char.us.oracle.com> References: <20180606192714.754943543@linutronix.de> <20180606192807.498338517@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20180606192807.498338517@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Wed, Jun 06, 2018 at 09:27:21PM +0200, speck for Thomas Gleixner wrote: > Subject: [patch V2 07/12] x86/cpu/AMD: Remove the pointless detect_ht() call > From: Thomas Gleixner > > Real 32bit AMD CPUs do not have SMT and the only value of the call was to > reach the magic printout which got removed. > > Signed-off-by: Thomas Gleixner Reviewed-by: Konrad Rzeszutek Wilk Thank you! > --- > arch/x86/kernel/cpu/amd.c | 4 ---- > 1 file changed, 4 deletions(-) > > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -855,10 +855,6 @@ static void init_amd(struct cpuinfo_x86 > srat_detect_node(c); > } > > -#ifdef CONFIG_X86_32 > - detect_ht(c); > -#endif > - > init_amd_cacheinfo(c); > > if (c->x86 >= 0xf) >