All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] get-versions: fix typo in fsverity.ver
Date: Mon, 11 Jun 2018 21:41:40 -0400	[thread overview]
Message-ID: <20180612014140.GA4436@thunk.org> (raw)
In-Reply-To: <1528719237-1278-1-git-send-email-amir73il@gmail.com>

On Mon, Jun 11, 2018 at 03:13:57PM +0300, Amir Goldstein wrote:
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

Applied, thanks.

> BTW, why are fsverity and ima-evm-utils required and not
> optional repos?

My general rule of thumb has been to include everything needed for
xfstests on kvm-xfstests and gce-xfstest, but not things needed for
android-xfstests.

The fsverity and ima-evm-utils git repos don't technically meet that
definition yet, but there are patches for tests for fsverity that
would require fsverity.  I've been investigating ways of allow IMA to
use fsverity, so that's why I had included it, but it's certainly much
more of a pre-emptive inclusion compared to fsverity.

Part of it is that adding optional repos means I have to test the
build and test appliance generation with and without the repo, so it's
a tiny bit more work/complexity, and I decided to be lazy / keep
things simple.

If the inclusion of ima-evm-utils is annoying, we could look at making
it be optional.

Cheers,

						- Ted

      reply	other threads:[~2018-06-12  1:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 12:13 [PATCH] get-versions: fix typo in fsverity.ver Amir Goldstein
2018-06-12  1:41 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612014140.GA4436@thunk.org \
    --to=tytso@mit.edu \
    --cc=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.