From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH 1/7] vhost: announce VIRTIO_F_IN_ORDER support
Date: Wed, 13 Jun 2018 14:18:39 +0800
Message-ID: <20180613061839.GA26433@debian>
References: <20180608090724.20855-1-yong.liu@intel.com>
 <20180608090724.20855-2-yong.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
To: Marvin Liu <yong.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 1215C1EE49
 for <dev@dpdk.org>; Wed, 13 Jun 2018 08:18:36 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180608090724.20855-2-yong.liu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 08, 2018 at 05:07:18PM +0800, Marvin Liu wrote:
[...]
> @@ -853,6 +853,10 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>  	vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
>  	vsocket->features           = VIRTIO_NET_SUPPORTED_FEATURES;
>  
> +	/* Dequeue zero copy can't assure descriptors returned in order */
> +	if (vsocket->dequeue_zero_copy)
> +		vsocket->features &= ~(1ULL << VIRTIO_F_IN_ORDER);

You also need to clear this bit from
vsocket->supported_features.

Thanks