All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Coly Li <colyli@suse.de>,
	linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/6] block: add a bio_reuse helper
Date: Wed, 13 Jun 2018 15:59:15 +0200	[thread overview]
Message-ID: <20180613135915.GC32418@lst.de> (raw)
In-Reply-To: <20180613085441.GA15100@kmo-pixel>

On Wed, Jun 13, 2018 at 04:54:41AM -0400, Kent Overstreet wrote:
> bi_size is not immutable though, it will usually be modified by drivers when you
> submit a bio.
> 
> I see what you're trying to do, but your approach is busted given the way the
> block layer works today. You'd have to save bio->bi_iter before submitting the
> bio and restore it afterwards for it to work.

For bi_size, agreed this needs fixing.  bi_sector is always restored
already by the callers, and the remaining fields are zeroed by bio_reset,
which does the right thing.

  reply	other threads:[~2018-06-13 13:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 19:48 [RFC] cleanup bcache bio handling Christoph Hellwig
2018-06-11 19:48 ` [PATCH 1/6] block: add a bio_reuse helper Christoph Hellwig
2018-06-12  6:16   ` Kent Overstreet
2018-06-13  7:32     ` Christoph Hellwig
2018-06-13  8:54       ` Kent Overstreet
2018-06-13 13:59         ` Christoph Hellwig [this message]
2018-06-13 14:49           ` Kent Overstreet
2018-06-11 19:48 ` [PATCH 2/6] bcache: use bio_reuse instead of bio_reinit where applicable Christoph Hellwig
2018-06-11 19:48 ` [PATCH 3/6] bcache: clean up bio reuse for struct moving_io Christoph Hellwig
2018-06-11 19:48 ` [PATCH 4/6] bcache: clean up bio reuse for struct dirty_io Christoph Hellwig
2018-06-11 19:48 ` [PATCH 5/6] bcache: don't clone bio in bch_data_verify Christoph Hellwig
2018-06-11 19:48 ` [PATCH 6/6] bcache: use bio_add_page instead of open coded bio manipulation Christoph Hellwig
2018-06-12  4:40 ` [RFC] cleanup bcache bio handling Coly Li
2018-06-13  9:58 ` Kent Overstreet
2018-06-13 11:06   ` Ming Lei
2018-06-13 13:56     ` Christoph Hellwig
2018-06-13 14:54       ` Kent Overstreet
2018-06-14  1:55         ` Ming Lei
2018-06-14  7:20           ` Christoph Hellwig
2018-06-13 13:51 [RFC] cleanup bcache bio handling v2 Christoph Hellwig
2018-06-13 13:51 ` [PATCH 1/6] block: add a bio_reuse helper Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613135915.GC32418@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.