From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: willy@infradead.org, manoj@linux.vnet.ibm.com,
ukrishn@linux.vnet.ibm.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, sabyasachi.linux@gmail.com,
brajeswar.linux@gmail.com
Subject: Re: [PATCH] scsi: cxlflash: Change return type for fault handler
Date: Wed, 13 Jun 2018 18:23:47 -0500 [thread overview]
Message-ID: <20180613232347.GA3851@p8tul1-build.aus.stglabs.ibm.com> (raw)
In-Reply-To: <20180611194204.GA18687@jordon-HP-15-Notebook-PC>
On Tue, Jun 12, 2018 at 01:12:04AM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
This looks fine to me.
FYI that there is another handler for this driver in a series
destined for 4.18 and currently in next/master.
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
next prev parent reply other threads:[~2018-06-13 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 19:42 [PATCH] scsi: cxlflash: Change return type for fault handler Souptick Joarder
2018-06-13 23:23 ` Matthew R. Ochs [this message]
2018-06-19 5:10 ` Souptick Joarder
2018-06-19 14:11 ` Uma Krishnan
2018-06-19 17:41 ` Souptick Joarder
2018-06-19 23:29 ` Matthew R. Ochs
2018-06-20 1:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613232347.GA3851@p8tul1-build.aus.stglabs.ibm.com \
--to=mrochs@linux.vnet.ibm.com \
--cc=brajeswar.linux@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manoj@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=sabyasachi.linux@gmail.com \
--cc=ukrishn@linux.vnet.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.