From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 1B15DC433EF for ; Thu, 14 Jun 2018 13:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C00C2208D8 for ; Thu, 14 Jun 2018 13:42:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C00C2208D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755232AbeFNNms (ORCPT ); Thu, 14 Jun 2018 09:42:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:39774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754914AbeFNNmp (ORCPT ); Thu, 14 Jun 2018 09:42:45 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32AB220020; Thu, 14 Jun 2018 13:42:44 +0000 (UTC) Date: Thu, 14 Jun 2018 09:42:42 -0400 From: Steven Rostedt To: Juri Lelli Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, lizefan@huawei.com, cgroups@vger.kernel.org Subject: Re: [PATCH v4 3/5] sched/core: Streamlining calls to task_rq_unlock() Message-ID: <20180614094242.36127604@gandalf.local.home> In-Reply-To: <20180613121711.5018-4-juri.lelli@redhat.com> References: <20180613121711.5018-1-juri.lelli@redhat.com> <20180613121711.5018-4-juri.lelli@redhat.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jun 2018 14:17:09 +0200 Juri Lelli wrote: > From: Mathieu Poirier > > Calls to task_rq_unlock() are done several times in function > __sched_setscheduler(). This is fine when only the rq lock needs to be > handled but not so much when other locks come into play. > > This patch streamlines the release of the rq lock so that only one > location need to be modified when dealing with more than one lock. > > No change of functionality is introduced by this patch. > > Signed-off-by: Mathieu Poirier Reviewed-by: Steven Rostedt (VMware) -- Steve