From: Christoph Hellwig <hch@lst.de>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Avi Kivity <avi@scylladb.com>, Benjamin LaHaise <bcrl@kvack.org>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-kernel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH v1] aio: mark __aio_sigset::sigmask const
Date: Thu, 14 Jun 2018 14:16:28 +0200 [thread overview]
Message-ID: <20180614121628.GA27117@lst.de> (raw)
In-Reply-To: <20180608145505.29063-1-avi@scylladb.com>
On Fri, Jun 08, 2018 at 05:55:05PM +0300, Avi Kivity wrote:
> io_pgetevents() will not change the signal mask. Mark it const
> to make it clear and to reduce the need for casts in user code.
>
> Signed-off-by: Avi Kivity <avi@scylladb.com>
Al, can you pick this one and the masking fix before -rc1?
> ---
> include/uapi/linux/aio_abi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
> index ed0185945bb2..cdf115b03761 100644
> --- a/include/uapi/linux/aio_abi.h
> +++ b/include/uapi/linux/aio_abi.h
> @@ -106,11 +106,11 @@ struct iocb {
>
> #undef IFBIG
> #undef IFLITTLE
>
> struct __aio_sigset {
> - sigset_t __user *sigmask;
> + const sigset_t __user *sigmask;
> size_t sigsetsize;
> };
>
> #endif /* __LINUX__AIO_ABI_H */
>
> --
> 2.14.4
---end quoted text---
prev parent reply other threads:[~2018-06-14 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 14:55 [PATCH v1] aio: mark __aio_sigset::sigmask const Avi Kivity
2018-06-11 6:56 ` Christoph Hellwig
2018-06-14 12:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614121628.GA27117@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.