From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v7 01/22] kvargs: build before EAL Date: Thu, 14 Jun 2018 15:10:11 +0100 Message-ID: <20180614141010.GA17668@bricha3-MOBL.ger.corp.intel.com> References: <26f020df392dcaa7f50dce1048af9526bf4cb8ab.1523804657.git.gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Gaetan Rivet Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 146791D8E5 for ; Thu, 14 Jun 2018 16:10:16 +0200 (CEST) Content-Disposition: inline In-Reply-To: <26f020df392dcaa7f50dce1048af9526bf4cb8ab.1523804657.git.gaetan.rivet@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Apr 15, 2018 at 05:07:30PM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/Makefile | 3 +-- > lib/librte_eal/common/Makefile | 2 +- > lib/librte_kvargs/Makefile | 3 ++- > lib/librte_kvargs/rte_kvargs.c | 2 +- > lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h | 0 > 5 files changed, 5 insertions(+), 5 deletions(-) > rename lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h (100%) > This fails for me when building DPDK for shared libs, due to the dependency on rte_log. I think if we to have kvargs built first it needs to be completely independent. /Bruce