✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/gtt: Add read only pages to gen8_pte_encode

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [1/5] drm/i915/gtt: Add read only pages to gen8_pte_encode
URL   : https://patchwork.freedesktop.org/series/44776/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a55b1e45685a drm/i915/gtt: Add read only pages to gen8_pte_encode
6ac74b295f59 drm/i915/gtt: Read-only pages for insert_entries on bdw+
-:188: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield.  Prefer bool bitfields as unsigned int or u<8|16|32>
#188: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:330:
+	bool pt_kmap_wc:1;

-:191: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield.  Prefer bool bitfields as unsigned int or u<8|16|32>
#191: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:333:
+	bool has_read_only:1;

-:288: WARNING:LINE_SPACING: Missing a blank line after declarations
#288: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:465:
+	struct drm_file *file;
+	I915_RND_STATE(prng);

-:358: ERROR:CODE_INDENT: code indent should use tabs where possible
#358: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:535:
+^I       ^Indwords, INTEL_INFO(i915)->num_rings);$

-:358: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#358: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:535:
+^I       ^Indwords, INTEL_INFO(i915)->num_rings);$

-:358: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#358: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:535:
+	pr_info("Submitted %lu dwords (across %u engines)\n",
+	       	ndwords, INTEL_INFO(i915)->num_rings);

total: 1 errors, 4 warnings, 1 checks, 342 lines checked
35e5b57aef3d drm/i915: Prevent writing into a read-only object via a GGTT mmap
-:176: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield.  Prefer bool bitfields as unsigned int or u<8|16|32>
#176: FILE: include/drm/drm_vma_manager.h:44:
+	bool readonly:1;

total: 0 errors, 1 warnings, 0 checks, 114 lines checked
fd5cf6c7adcd drm/i915: Reject attempted pwrites into a read-only object
2a4d290f8b3e drm/i915/userptr: Enable read-only support on gen8+

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx