From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 28/24] drm/i915/icl: implement DVFS for ICL Date: Thu, 14 Jun 2018 12:47:26 -0700 Message-ID: <20180614194726.GO8374@intel.com> References: <20180522002558.29262-1-paulo.r.zanoni@intel.com> <20180524234241.3665-1-paulo.r.zanoni@intel.com> <20180524234241.3665-4-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5262A6E8D0 for ; Thu, 14 Jun 2018 19:47:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180524234241.3665-4-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMjQsIDIwMTggYXQgMDQ6NDI6MzlQTSAtMDcwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IElDTCBEVkZTIGlzIGFsbW9zdCB0aGUgc2FtZSBhcyBDTkwsIGV4Y2VwdCBmb3IgdGhl IENEQ0xLL0RESUNMSwo+IHRhYmxlLiBJbXBsZW1lbnQgaXQganVzdCBsaWtlIENOTCBkb2VzLgo+ IAo+IFJlZmVyZW5jZXM6IGNvbW1pdCA0ODQ2OWVjZWQyODIgKCJkcm0vaTkxNTogVXNlIGNkY2xr X3N0YXRlLT52b2x0YWdlCj4gIG9uIENOTCIpCj4gUmVmZXJlbmNlczogY29tbWl0IDUzZTliZjVl ODE1OSAoImRybS9pOTE1OiBBZGp1c3Qgc3lzdGVtIGFnZW50Cj4gIHZvbHRhZ2Ugb24gQ05MIGlm IHJlcXVpcmVkIGJ5IERESSBwb3J0cyIpCj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVs by5yLnphbm9uaUBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdv LnZpdmlAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2Rj bGsuYyB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jICAgfCAgMiArKwo+ICAyIGZpbGVzIGNoYW5nZWQs IDQ1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jZGNsay5jCj4gaW5kZXggNzA0ZGRiNGQzY2E3Li42NDJmMWU1NDJhNjIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiBAQCAtMTg2MSwxMSArMTg2MSwzNSBAQCBzdGF0aWMg dm9pZCBpY2xfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg CQkJICAgICAgc2tsX2NkY2xrX2RlY2ltYWwoY2RjbGspKTsKPiAgCj4gIAltdXRleF9sb2NrKCZk ZXZfcHJpdi0+cGN1X2xvY2spOwo+IC0JLyogVE9ETzogYWRkIHByb3BlciBEVkZTIHN1cHBvcnQu ICovCj4gLQlzYW5keWJyaWRnZV9wY29kZV93cml0ZShkZXZfcHJpdiwgU0tMX1BDT0RFX0NEQ0xL X0NPTlRST0wsIDIpOwo+ICsJc2FuZHlicmlkZ2VfcGNvZGVfd3JpdGUoZGV2X3ByaXYsIFNLTF9Q Q09ERV9DRENMS19DT05UUk9MLAo+ICsJCQkJY2RjbGtfc3RhdGUtPnZvbHRhZ2VfbGV2ZWwpOwo+ ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cGN1X2xvY2spOwo+ICAKPiAgCWludGVsX3VwZGF0 ZV9jZGNsayhkZXZfcHJpdik7Cj4gKwo+ICsJLyoKPiArCSAqIENhbid0IHJlYWQgb3V0IHRoZSB2 b2x0YWdlIGxldmVsIDooCj4gKwkgKiBMZXQncyBqdXN0IGFzc3VtZSBldmVyeXRoaW5nIGlzIGFz IGV4cGVjdGVkLgo+ICsJICovCj4gKwlkZXZfcHJpdi0+Y2RjbGsuaHcudm9sdGFnZV9sZXZlbCA9 IGNkY2xrX3N0YXRlLT52b2x0YWdlX2xldmVsOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdTggaWNsX2Nh bGNfdm9sdGFnZV9sZXZlbChpbnQgY2RjbGspCj4gK3sKPiArCXN3aXRjaCAoY2RjbGspIHsKPiAr CWNhc2UgNTAwMDA6Cj4gKwljYXNlIDMwNzIwMDoKPiArCWNhc2UgMzEyMDAwOgo+ICsJCXJldHVy biAwOwo+ICsJY2FzZSA1NTY4MDA6Cj4gKwljYXNlIDU1MjAwMDoKPiArCQlyZXR1cm4gMTsKPiAr CWRlZmF1bHQ6Cj4gKwkJTUlTU0lOR19DQVNFKGNkY2xrKTsKPiArCWNhc2UgNjUyODAwOgo+ICsJ Y2FzZSA2NDgwMDA6Cj4gKwkJcmV0dXJuIDI7Cj4gKwl9Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lk IGljbF9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IEBAIC0x ODk5LDcgKzE5MjMsNyBAQCBzdGF0aWMgdm9pZCBpY2xfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkgKi8KPiAgCQljZGNsa19zdGF0ZS0+dmNvID0gMDsK PiAgCQljZGNsa19zdGF0ZS0+Y2RjbGsgPSBjZGNsa19zdGF0ZS0+YnlwYXNzOwo+IC0JCXJldHVy bjsKPiArCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4gIAljZGNsa19zdGF0ZS0+dmNvID0gKHZhbCAm IEJYVF9ERV9QTExfUkFUSU9fTUFTSykgKiBjZGNsa19zdGF0ZS0+cmVmOwo+IEBAIC0xOTA4LDYg KzE5MzIsMTQgQEAgc3RhdGljIHZvaWQgaWNsX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gIAlXQVJOX09OKCh2YWwgJiBCWFRfQ0RDTEtfQ0QyWF9ESVZfU0VM X01BU0spICE9IDApOwo+ICAKPiAgCWNkY2xrX3N0YXRlLT5jZGNsayA9IGNkY2xrX3N0YXRlLT52 Y28gLyAyOwo+ICsKPiArb3V0Ogo+ICsJLyoKPiArCSAqIENhbid0IHJlYWQgdGhpcyBvdXQgOigg TGV0J3MgYXNzdW1lIGl0J3MKPiArCSAqIGF0IGxlYXN0IHdoYXQgdGhlIENEQ0xLIGZyZXF1ZW5j eSByZXF1aXJlcy4KPiArCSAqLwo+ICsJY2RjbGtfc3RhdGUtPnZvbHRhZ2VfbGV2ZWwgPQo+ICsJ CWljbF9jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2RjbGtfc3RhdGUtPmNkY2xrKTsKPiAgfQo+ICAKPiAg LyoqCj4gQEAgLTE5NTAsNiArMTk4Miw4IEBAIHZvaWQgaWNsX2luaXRfY2RjbGsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJc2FuaXRpemVkX3N0YXRlLmNkY2xrID0gaWNs X2NhbGNfY2RjbGsoMCwgc2FuaXRpemVkX3N0YXRlLnJlZik7Cj4gIAlzYW5pdGl6ZWRfc3RhdGUu dmNvID0gaWNsX2NhbGNfY2RjbGtfcGxsX3ZjbyhkZXZfcHJpdiwKPiAgCQkJCQkJICAgICBzYW5p dGl6ZWRfc3RhdGUuY2RjbGspOwo+ICsJc2FuaXRpemVkX3N0YXRlLnZvbHRhZ2VfbGV2ZWwgPQo+ ICsJCQkJaWNsX2NhbGNfdm9sdGFnZV9sZXZlbChzYW5pdGl6ZWRfc3RhdGUuY2RjbGspOwo+ICAK PiAgCWljbF9zZXRfY2RjbGsoZGV2X3ByaXYsICZzYW5pdGl6ZWRfc3RhdGUpOwo+ICB9Cj4gQEAg LTE5NjcsNiArMjAwMSw3IEBAIHZvaWQgaWNsX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJY2RjbGtfc3RhdGUuY2RjbGsgPSBjZGNsa19zdGF0 ZS5ieXBhc3M7Cj4gIAljZGNsa19zdGF0ZS52Y28gPSAwOwo+ICsJY2RjbGtfc3RhdGUudm9sdGFn ZV9sZXZlbCA9IGljbF9jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2RjbGtfc3RhdGUuY2RjbGspOwo+ICAK PiAgCWljbF9zZXRfY2RjbGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSk7Cj4gIH0KPiBAQCAtMjQ3 MCw2ICsyNTA1LDkgQEAgc3RhdGljIGludCBpY2xfbW9kZXNldF9jYWxjX2NkY2xrKHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCj4gIAlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNh bC52Y28gPSB2Y287Cj4gIAlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC5jZGNsayA9IGNkY2xr Owo+ICsJaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWwudm9sdGFnZV9sZXZlbCA9Cj4gKwkJbWF4 KGljbF9jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2RjbGspLAo+ICsJCSAgICBjbmxfY29tcHV0ZV9taW5f dm9sdGFnZV9sZXZlbChpbnRlbF9zdGF0ZSkpOwo+ICAKPiAgCWlmICghaW50ZWxfc3RhdGUtPmFj dGl2ZV9jcnRjcykgewo+ICAJCWNkY2xrID0gaWNsX2NhbGNfY2RjbGsoMCwgcmVmKTsKPiBAQCAt MjQ3Nyw2ICsyNTE1LDggQEAgc3RhdGljIGludCBpY2xfbW9kZXNldF9jYWxjX2NkY2xrKHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCj4gIAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFj dHVhbC52Y28gPSB2Y287Cj4gIAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbC5jZGNsayA9IGNk Y2xrOwo+ICsJCWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwudm9sdGFnZV9sZXZlbCA9Cj4gKwkJ CWljbF9jYWxjX3ZvbHRhZ2VfbGV2ZWwoY2RjbGspOwo+ICAJfSBlbHNlIHsKPiAgCQlpbnRlbF9z dGF0ZS0+Y2RjbGsuYWN0dWFsID0gaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWw7Cj4gIAl9Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCA2MTBjMmQ3ZDQ5OWMuLjZjZGNiZjliZjA5 OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTMwNzMsNiArMzA3Myw4IEBA IHZvaWQgaW50ZWxfZGRpX2NvbXB1dGVfbWluX3ZvbHRhZ2VfbGV2ZWwoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICB7Cj4gIAlpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikg JiYgY3J0Y19zdGF0ZS0+cG9ydF9jbG9jayA+IDU5NDAwMCkKPiAgCQljcnRjX3N0YXRlLT5taW5f dm9sdGFnZV9sZXZlbCA9IDI7Cj4gKwllbHNlIGlmIChJU19JQ0VMQUtFKGRldl9wcml2KSAmJiBj cnRjX3N0YXRlLT5wb3J0X2Nsb2NrID4gNTk0MDAwKQo+ICsJCWNydGNfc3RhdGUtPm1pbl92b2x0 YWdlX2xldmVsID0gMTsKPiAgfQo+ICAKPiAgdm9pZCBpbnRlbF9kZGlfZ2V0X2NvbmZpZyhzdHJ1 Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAtLSAKPiAyLjE0LjMKPiAKPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5n IGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==