All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>,
	David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region()
Date: Fri, 15 Jun 2018 13:24:56 +0200	[thread overview]
Message-ID: <20180615112500.19854-9-david@redhat.com> (raw)
In-Reply-To: <20180615112500.19854-1-david@redhat.com>

Our parent class (PC_DIMM) provides exactly the same function.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 hw/mem/nvdimm.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index 37e19044d6..df9716231f 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice *nvdimm, const void *buf,
     memory_region_set_dirty(mr, backend_offset, size);
 }
 
-static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
-{
-    return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
-}
-
 static void nvdimm_class_init(ObjectClass *oc, void *data)
 {
     PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc);
@@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void *data)
 
     ddc->realize = nvdimm_realize;
     ddc->get_memory_region = nvdimm_get_memory_region;
-    ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region;
 
     nvc->read_label_data = nvdimm_read_label_data;
     nvc->write_label_data = nvdimm_write_label_data;
-- 
2.17.1

  parent reply	other threads:[~2018-06-15 11:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 11:24 [Qemu-devel] [PATCH v2 00/12] pc-dimm: next bunch of cleanups David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity" David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)* David Hildenbrand
2018-06-15 11:51   ` Igor Mammedov
2018-06-15 11:52     ` David Hildenbrand
2018-06-15 12:31       ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_* David Hildenbrand
2018-06-15 12:33   ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header David Hildenbrand
2018-06-15 12:36   ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug() David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory() David Hildenbrand
2018-06-15 12:39   ` Igor Mammedov
2018-06-15 12:45     ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 07/12] pc-dimm: merge get_(vmstate_)memory_region() David Hildenbrand
2018-06-15 12:45   ` Igor Mammedov
2018-06-15 11:24 ` David Hildenbrand [this message]
2018-06-15 12:46   ` [Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region() Igor Mammedov
2018-06-15 12:50     ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 09/12] nvdimm: convert "unarmed" into a static property David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 10/12] nvdimm: convert "label-size" " David Hildenbrand
2018-06-15 12:53   ` Igor Mammedov
2018-06-15 13:30     ` David Hildenbrand
2018-06-15 13:40       ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 11/12] nvdimm: make get_memory_region() perform checks and initialization David Hildenbrand
2018-06-15 13:14   ` Igor Mammedov
2018-06-15 11:25 ` [Qemu-devel] [PATCH v2 12/12] pc-dimm: get_memory_region() will not fail after realize David Hildenbrand
2018-06-15 13:19   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615112500.19854-9-david@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.