All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/8] x86/microcode/AMD: Check microcode container data in the early loader
Date: Fri, 15 Jun 2018 13:42:54 +0200	[thread overview]
Message-ID: <20180615114253.GD25559@zn.tnic> (raw)
In-Reply-To: <7c47bfe2-3293-2973-d9bb-daa218d5751b@maciej.szmigiero.name>

On Thu, Jun 14, 2018 at 10:56:07PM +0200, Maciej S. Szmigiero wrote:
> At this point we don't know the CPU family the particular patch is for
> since the patch header contains only CPU rev_id, not an explicit family
> number.

	patch_fam = 0xf + (mc->processor_rev_id >> 12);

which means, you can do

        if (patch_fam != family)
                return 0;

like verify_and_add_patch() does before calling verify_patch() with the
correct family of the current CPU.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-06-15 11:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19 22:07 [PATCH v6 0/8] x86/microcode/AMD: Check microcode file sanity before loading it Maciej S. Szmigiero
2018-05-19 22:07 ` [PATCH v6 1/8] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length Maciej S. Szmigiero
2018-05-19 22:07 ` [PATCH v6 2/8] x86/microcode/AMD: Add microcode container data checking functions Maciej S. Szmigiero
2018-06-05  8:54   ` Borislav Petkov
2018-05-19 22:07 ` [PATCH v6 3/8] x86/microcode/AMD: Check microcode container data in the early loader Maciej S. Szmigiero
2018-06-05  8:54   ` Borislav Petkov
2018-06-14 20:56     ` Maciej S. Szmigiero
2018-06-15 11:42       ` Borislav Petkov [this message]
2018-05-19 22:07 ` [PATCH v6 4/8] x86/microcode/AMD: Split status from data to skip in verify_and_add_patch() Maciej S. Szmigiero
2018-05-19 22:07 ` [PATCH v6 5/8] x86/microcode/AMD: Check microcode container data in the late loader Maciej S. Szmigiero
2018-06-05  8:54   ` Borislav Petkov
2018-05-19 22:07 ` [PATCH v6 6/8] x86/microcode/AMD: Integrate verify_patch_size() into verify_patch() Maciej S. Szmigiero
2018-05-19 22:07 ` [PATCH v6 7/8] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro Maciej S. Szmigiero
2018-05-19 22:07 ` [PATCH v6 8/8] x86/microcode/AMD: Don't scan past the CPU equivalence table data Maciej S. Szmigiero
2018-06-05  8:55   ` Borislav Petkov
2018-06-12 21:08     ` Maciej S. Szmigiero
2018-06-18 16:44       ` Borislav Petkov
2018-06-18 18:11         ` Maciej S. Szmigiero
2018-06-18 18:30           ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615114253.GD25559@zn.tnic \
    --to=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.