All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
	linux-raid@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Yury Norov <ynorov@caviumnetworks.com>,
	linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 4/5] Input: gpio-keys - Switch to bitmap_zalloc()
Date: Fri, 15 Jun 2018 16:20:16 +0300	[thread overview]
Message-ID: <20180615132017.23889-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20180615132017.23889-1-andriy.shevchenko@linux.intel.com>

Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/input/keyboard/gpio_keys.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 052e37675086..492a971b95b5 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -196,7 +196,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
 	ssize_t ret;
 	int i;
 
-	bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL);
+	bits = bitmap_zalloc(n_events, GFP_KERNEL);
 	if (!bits)
 		return -ENOMEM;
 
@@ -216,7 +216,7 @@ static ssize_t gpio_keys_attr_show_helper(struct gpio_keys_drvdata *ddata,
 	buf[ret++] = '\n';
 	buf[ret] = '\0';
 
-	kfree(bits);
+	bitmap_free(bits);
 
 	return ret;
 }
@@ -240,7 +240,7 @@ static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
 	ssize_t error;
 	int i;
 
-	bits = kcalloc(BITS_TO_LONGS(n_events), sizeof(*bits), GFP_KERNEL);
+	bits = bitmap_zalloc(n_events, GFP_KERNEL);
 	if (!bits)
 		return -ENOMEM;
 
@@ -284,7 +284,7 @@ static ssize_t gpio_keys_attr_store_helper(struct gpio_keys_drvdata *ddata,
 	mutex_unlock(&ddata->disable_lock);
 
 out:
-	kfree(bits);
+	bitmap_free(bits);
 	return error;
 }
 
-- 
2.17.1

  parent reply	other threads:[~2018-06-15 13:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 13:20 [PATCH v2 0/5] bitmap: Introduce alloc/free helpers Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 1/5] md: Avoid namespace collision with bitmap API Andy Shevchenko
2018-06-15 15:09   ` kbuild test robot
2018-06-15 15:09     ` kbuild test robot
2018-06-15 14:58     ` Andy Shevchenko
2018-06-18 13:36       ` Mike Snitzer
2018-06-15 15:19   ` kbuild test robot
2018-06-15 15:19     ` kbuild test robot
2018-06-15 13:20 ` [PATCH v2 2/5] bitmap: Drop unnecessary 0 check for u32 array operations Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free() Andy Shevchenko
2018-06-15 22:23   ` Yury Norov
2018-06-16 18:42     ` Andy Shevchenko
2018-06-15 13:20 ` Andy Shevchenko [this message]
2018-06-15 22:06   ` [PATCH v2 4/5] Input: gpio-keys - Switch to bitmap_zalloc() Yury Norov
2018-06-16 18:50     ` Andy Shevchenko
2018-06-15 13:20 ` [PATCH v2 5/5] Input: evdev " Andy Shevchenko
2018-06-15 21:42   ` Yury Norov
2018-06-16 18:45     ` Andy Shevchenko
2018-06-16 19:16       ` Joe Perches
2018-06-18 12:02         ` Andy Shevchenko
2018-06-18 15:49           ` Joe Perches
2018-06-18 19:56             ` Andy Shevchenko
2018-06-18 20:40               ` Joe Perches
2018-06-19 18:33     ` Dmitry Torokhov
2018-06-20  8:13       ` Yury Norov
2018-06-20  8:13         ` Yury Norov
2018-06-20 20:26         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615132017.23889-5-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=shli@kernel.org \
    --cc=snitzer@redhat.com \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.