From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839B8C5CFC0 for ; Mon, 18 Jun 2018 08:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3477D20864 for ; Mon, 18 Jun 2018 08:20:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TWkussDy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3477D20864 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964914AbeFRIUZ (ORCPT ); Mon, 18 Jun 2018 04:20:25 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39390 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935671AbeFRIUU (ORCPT ); Mon, 18 Jun 2018 04:20:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qzjxJTYmO3lWkgYuepOEm8/PCjYc9A3wNMYrNSoX8XQ=; b=TWkussDyToZBtOlE+gHWu9/jD p0oTdSiR7yNnFceKJ1DbhjIjhD5Z8yqHpWrwcVKrK/CshSBuFq97NYa4hlGqILA1k+QTj4Q/dNdDt ZKfCYiMWKmc5bXOqIE96DBrCFj5oRahA4Sp95JGcF7bqqICiawTRNU99K8O9PL4gmDyS/Ra/AIKb8 K+eviIgHHf60pBS+A1fKCPOWrZSl+RX6KBhH1NqWzwgYm9HB+/COqdow/OE0++HpWNVrEPegG+0CV vMBTwXTS1amnlRREjaESGDbc5PEnTZTdXbgPefNcd8vpjFwYgpWYC2aPMpwnQcR7okbANy8rpOt+W trvUYxk/Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fUpOb-00029d-EM; Mon, 18 Jun 2018 08:20:17 +0000 Date: Mon, 18 Jun 2018 01:20:17 -0700 From: Christoph Hellwig To: NeilBrown Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [RFC PATCH 0/5] kbuild: build modules from code in multiple directories. Message-ID: <20180618082017.GA4752@infradead.org> References: <152929708853.17463.17302660556961083137.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152929708853.17463.17302660556961083137.stgit@noble> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2018 at 02:55:20PM +1000, NeilBrown wrote: > This set of patches makes it possible to build a module from > code in multiple directories without needing to list files from one > directory in the Makefile of another directory. > > The code was developed for lustre (which is now out-of-tree :-( ) but > can be useful elsewhere, such as for xfs and btrfs and others. > > In fs/xfs/Makefile the section: > > xfs-y += $(addprefix libxfs/, \ > xfs_ag.o \ > xfs_alloc.o \ > ..... > > could become > > xfs-y += libxfs/ > > and then in fs/xfs/libxfs/Makefile we would have > > modobj-$(CONFIG_XFS_FS) += xfs_ag.o \ > xfs_alloc.o \ > ..... > > A similar process could move filenames for scrub/* from the > fs/xfs/Makefile to fs/xfs/scrub/Makefile How about you actually convert it as an example?