From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 316E0C5CFC1 for ; Tue, 19 Jun 2018 05:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63D1120874 for ; Tue, 19 Jun 2018 05:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="G6wxSZ+i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63D1120874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbeFSFbo (ORCPT ); Tue, 19 Jun 2018 01:31:44 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:46047 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbeFSFbk (ORCPT ); Tue, 19 Jun 2018 01:31:40 -0400 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 420AE800E6; Tue, 19 Jun 2018 17:31:36 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail; t=1529386296; bh=gtOFZrCEbPq2FHKvbmVhauPPiPV97AvOKRG434gLOaw=; h=From:To:Cc:Subject:Date; b=G6wxSZ+i1EXrlyYQKPQwbcZkGpqqL1X+c2kBGgCRcbotIxP3JIF1gQCGJsV43JcJb kpY7uXvwgebPvf9nsVWm0klTJBKvWLOF2VVPZeHBcwX9G2nn9SmyqDsGh1lnwDtGAE m61b4n9piDRkDGKiUcBwCLUMykmXMmewxa0rj32g= Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7,5,8,10121) id ; Tue, 19 Jun 2018 17:31:36 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by smtp (Postfix) with ESMTP id D078713EEAD; Tue, 19 Jun 2018 17:31:38 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id B1F371E2626; Tue, 19 Jun 2018 17:31:35 +1200 (NZST) From: Chris Packham To: miquel.raynal@bootlin.com, boris.brezillon@bootlin.com, dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Chris Packham Subject: [RFC PATCH v2 0/6] mtd: rawnand: support MT29F1G08ABAFAWP-ITE:F Date: Tue, 19 Jun 2018 17:31:19 +1200 Message-Id: <20180619053125.16792-1-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I'm looking at adding support for the Micron MT29F1G08ABAFAWP-ITE:F chip to one of our boards which uses the Marvell NFCv2 controller. This particular chip is a bit odd in that the datasheet states support for ONFI 1.0 but the revision number field is 00 00. It also is marked ABAFA but reports internally as ABAGA. Finally it has internal 8-bit ECC which cannot be disabled. The existing test in micron_supports_on_die_ecc() determines that on-die ECC is supported but not mandatory but I know for this chip it is mandatory despite what set_features returns. In order for this to work I need to set nand-ecc-mode = "on-die" in my dts. Ideally I'd like it to be automatic based on what the hardware can support but that may be asking too much at the moment. I think I need to do some re-testing on other Micron parts so this series is still RFC. Although the first 3 patches are probably good to go. Here's a dump of the parameter page from the chip I have 00000000: 4f 4e 46 49 00 00 18 00 3f 00 00 00 00 00 00 00 ONFI....?....... 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00000020: 4d 49 43 52 4f 4e 20 20 20 20 20 20 4d 54 32 39 MICRON MT29 00000030: 46 31 47 30 38 41 42 41 47 41 57 50 20 20 20 20 F1G08ABAGAWP 00000040: 2c 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ,............... 00000050: 00 08 00 00 80 00 00 02 00 00 20 00 40 00 00 00 .......... .@... 00000060: 00 04 00 00 01 22 01 14 00 01 05 08 00 00 04 00 .....".......... 00000070: 08 01 0e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00000080: 08 3f 00 3f 00 58 02 10 27 46 00 64 00 00 00 00 .?.?.X..'F.d.... 00000090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 000000a0: 00 00 00 00 01 00 00 00 00 02 04 80 01 81 04 03 ................ 000000b0: 02 01 1e 90 00 00 00 00 00 00 00 00 00 00 00 00 ................ 000000c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 000000d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 000000e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 000000f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 85 a6 ................ Chris Packham (6): mtd: rawnand: marvell: Handle on-die ECC mtd: rawnand: add manufacturer fixup for ONFI parameter page mtd: rawnand: micron: add fixup for ONFI revision mtd: rawnand: marvell: Support page size of 2048 with 8-bit ECC mtd: rawnand: micron: add ONFI_FEATURE_ON_DIE_ECC to supported features mtd: rawnand: micron: support 8/512 on-die ECC drivers/mtd/nand/raw/marvell_nand.c | 2 ++ drivers/mtd/nand/raw/nand_base.c | 4 ++++ drivers/mtd/nand/raw/nand_micron.c | 18 ++++++++++++++---- include/linux/mtd/rawnand.h | 1 + 4 files changed, 21 insertions(+), 4 deletions(-) -- 2.17.1