All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Samuel Mendoza-Jonas <sam@mendozajonas.com>,
	"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: [PATCH v2 2/4] net/ncsi: Drop no more channels message
Date: Tue, 19 Jun 2018 15:08:32 +0930	[thread overview]
Message-ID: <20180619053834.12257-3-joel@jms.id.au> (raw)
In-Reply-To: <20180619053834.12257-1-joel@jms.id.au>

This does not provide useful information. As the ncsi maintainer said:

 > either we get a channel or broadcom has gone out to lunch

Acked-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 net/ncsi/ncsi-manage.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
index 616441c2b54f..716493a61ba6 100644
--- a/net/ncsi/ncsi-manage.c
+++ b/net/ncsi/ncsi-manage.c
@@ -1226,8 +1226,6 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp)
 		return ncsi_choose_active_channel(ndp);
 	}
 
-	netdev_printk(KERN_DEBUG, ndp->ndev.dev,
-		      "NCSI: No more channels to process\n");
 	ncsi_report_link(ndp, false);
 	return -ENODEV;
 }
-- 
2.17.1

  parent reply	other threads:[~2018-06-19  5:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19  5:38 [PATCH v2 0/4] Slience NCSI logging Joel Stanley
2018-06-19  5:38 ` [PATCH v2 1/4] net/ncsi: Silence debug messages Joel Stanley
2018-06-19  5:38 ` Joel Stanley [this message]
2018-06-19  5:38 ` [PATCH v2 3/4] net/ncsi: Use netdev_dbg for " Joel Stanley
2018-06-19  5:38 ` [PATCH v2 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI Joel Stanley
2018-06-19 22:27 ` [PATCH v2 0/4] Slience NCSI logging David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180619053834.12257-3-joel@jms.id.au \
    --to=joel@jms.id.au \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    --cc=sam@mendozajonas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.