From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH] crypto: skcipher: remove static declaration of export function Date: Tue, 19 Jun 2018 22:27:28 +0800 Message-ID: <20180619142727.7kvtuimjufvdacqn@gondor.apana.org.au> References: <20180617174959.29864-1-efremov@linux.com> <20180618172803.GA8022@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: efremov@linux.com, "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org To: Eric Biggers Return-path: Content-Disposition: inline In-Reply-To: <20180618172803.GA8022@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Jun 18, 2018 at 10:28:03AM -0700, Eric Biggers wrote: > On Sun, Jun 17, 2018 at 08:49:59PM +0300, efremov@linux.com wrote: > > The function skcipher_walk_next declared as static and marked as > > EXPORT_SYMBOL. It's a bit confusing since export symbol means that > > we want others to use this function. The area of visibility for such > > function is its .c file and all other modules. Other *.c files of the > > same module can't use it, despite all other modules can. Relying on > > that such behavior was not the original intention, the patch just > > removes the static keyword. > > > > Found by Linux Driver Verification project (linuxtesting.org). > > > > Signed-off-by: Denis Efremov > > Why not remove the EXPORT_SYMBOL instead? It has no users outside the file. I agree. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt