From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] ucc_geth: Add BQL support
Date: Wed, 20 Jun 2018 14:39:45 +0900 (KST)
Message-ID: <20180620.143945.116462011875467035.davem@davemloft.net>
References: <20180619163036.20578-1-joakim.tjernlund@infinera.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: leoyang.li@nxp.com, netdev@vger.kernel.org
To: joakim.tjernlund@infinera.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:55452 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751436AbeFTFjs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 20 Jun 2018 01:39:48 -0400
In-Reply-To: <20180619163036.20578-1-joakim.tjernlund@infinera.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Date: Tue, 19 Jun 2018 18:30:36 +0200

> @@ -3242,6 +3243,8 @@ static int ucc_geth_tx(struct net_device *dev, u8 txQ)
>  	struct ucc_geth_private *ugeth = netdev_priv(dev);
>  	u8 __iomem *bd;		/* BD pointer */
>  	u32 bd_status;
> +	int howmany = 0;
> +	unsigned int bytes_sent = 0;

Please keep the function local variable declarations ordered from
longest to shortest line.

Thank you.