From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb HC busted? From: Sudip Mukherjee Message-Id: <20180621005332.5uy74tkjoel6w4xy@debian> Date: Thu, 21 Jun 2018 01:53:32 +0100 To: Mathias Nyman , Andy Shevchenko Cc: Andy Shevchenko , Mathias Nyman , linux-usb@vger.kernel.org, lukaszx.szulc@intel.com, Christoph Hellwig , Marek Szyprowski , iommu@lists.linux-foundation.org List-ID: SGkgTWF0aGlhcywgQW5keSwKCk9uIFRodSwgSnVuIDA3LCAyMDE4IGF0IDEwOjQwOjAzQU0gKzAz MDAsIE1hdGhpYXMgTnltYW4gd3JvdGU6Cj4gT24gMDYuMDYuMjAxOCAxOTo0NSwgU3VkaXAgTXVr aGVyamVlIHdyb3RlOgo+ID4gSGkgQW5keSwKPiA+IAo+ID4gQW5kIHdlIG1lZXQgYWdhaW4uIDop Cj4gPiAKPiA+IE9uIFdlZCwgSnVuIDA2LCAyMDE4IGF0IDA2OjM2OjM1UE0gKzAzMDAsIEFuZHkg U2hldmNoZW5rbyB3cm90ZToKPiA+ID4gT24gV2VkLCAyMDE4LTA2LTA2IGF0IDE3OjEyICswMzAw LCBNYXRoaWFzIE55bWFuIHdyb3RlOgo+ID4gPiA+IE9uIDA0LjA2LjIwMTggMTg6MjgsIFN1ZGlw IE11a2hlcmplZSB3cm90ZToKPiA+ID4gPiA+IE9uIFRodSwgTWF5IDI0LCAyMDE4IGF0IDA0OjM1 OjM0UE0gKzAzMDAsIE1hdGhpYXMgTnltYW4gd3JvdGU6Cj4gPiA+ID4gPiA+IAo+ID4gPiAKPiA+ ID4gPiBPZGQgYW5kIHVubGlrZWx5LCBidXQgdG8gbWUgdGhpcyBsb29rcyBsaWtlIHNvbWUgaXNz dWUgaW4gYWxsb2NhdGluZwo+ID4gPiA+IGRtYSBtZW1vcnkKPiA+ID4gPiBmcm9tIHBvb2wgdXNp bmcgZG1hX3Bvb2xfemFsbG9jKCkKPiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBIZXJlJ3MgdGhl IHN0b3J5Ogo+ID4gPiA+IFN1ZGlwIHNlZXMgdXNiIGlzc3VlcyBvbiBhIEludGVsIEF0b20gYmFz ZWQgYm9hcmQgd2l0aCA0LjE0LjIga2VybmVsLgo+ID4gPiA+IEFsbCB0cmFjaW5nIHBvaW50cyB0 byBkbWFfcG9vbF96YWxsb2MoKSByZXR1cm5pbmcgdGhlIHNhbWUgZG1hIGFkZHJlc3MKPiA+ID4g PiBibG9jayBvbgo+ID4gPiA+IGNvbnNlY3V0aXZlIGNhbGxzLgo+ID4gPiA+IAo+ID4gPiA+IElu IHRoZSBmYWlsaW5nIGNhc2UgZG1hX3Bvb2xfemFsbG9jKCkgaXMgY2FsbGVkIDMgLSA2dXMgYXBh cnQuCj4gPiA+ID4gCj4gPiA+ID4gPC4uLj4tMjYzNjIgWzAwMl0gLi4uLiAgMTE4Ni43NTY3Mzk6 IHhoY2lfcmluZ19tZW1fZGV0YWlsOiBNQVRUVQo+ID4gPiA+IHhoY2lfc2VnbWVudF9hbGxvYyBk bWEgQCAweDAwMDAwMDAwMmQ5MmIwMDAKPiA+ID4gPiA8Li4uPi0yNjM2MiBbMDAyXSAuLi4uICAx MTg2Ljc1Njc0NTogeGhjaV9yaW5nX21lbV9kZXRhaWw6IE1BVFRVCj4gPiA+ID4geGhjaV9zZWdt ZW50X2FsbG9jIGRtYSBAIDB4MDAwMDAwMDAyZDkyYjAwMAo+ID4gPiA+IDwuLi4+LTI2MzYyIFsw MDJdIC4uLi4gIDExODYuNzU2NzQ4OiB4aGNpX3JpbmdfbWVtX2RldGFpbDogTUFUVFUKPiA+ID4g PiB4aGNpX3NlZ21lbnRfYWxsb2MgZG1hIEAgMHgwMDAwMDAwMDJkOTJiMDAwCj4gPiA+ID4gCj4g PiA+ID4gZG1hX3Bvb2xfemFsbG9jKCkgaXMgY2FsbGVkIGZyb20geGhjaV9zZWdtZW50X2FsbG9j KCkgaW4KPiA+ID4gPiBkcml2ZXJzL3VzYi9ob3N0L3hoY2ktbWVtLmMKPiA+ID4gPiBzZWU6Cj4g PiA+ID4gaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvdjQuMTQuMi9zb3VyY2UvZHJp dmVycy91c2IvaG9zdC94aGNpLQo+ID4gPiA+IG1lbS5jI0w1Mgo+ID4gPiA+IAo+ID4gPiA+IHBy aW50cyBhYm92ZSBhcmUgY3VzdG9tIHRyYWNlcyBhZGRlZCByaWdodCBhZnRlciBkbWFfcG9vbF96 YWxsb2MoKQo+ID4gPiAKPiA+ID4gRm9yIGJldHRlciB1bmRlcnN0YW5kaW5nIGl0IHdvdWxkIGJl IGdvb2QgdG8gaGF2ZSBkbWFfcG9vbF9mcmVlKCkgY2FsbHMKPiA+ID4gZGVidWdnZWQgYXMgd2Vs bC4KPiA+IAo+IAo+IFN1ZGlwIGhhcyBhIGZ1bGwgKDM5NE0gdW5wYWNrZWQpIHRyYWNlIGF0Ogo+ IGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS9vcGVuP2lkPTFoLTNyLTFsZmpnOG9ibEJHa3pkUklx OHozWk5nR1p4LQo+IAoKPHNuaXA+Cgo+IEJ1dCB0aGVuIGl0IGdldHMgc3R1Y2ssIGZvciB0aGUg d2hvbGUgcmluZzIgZG1hX3Bvb2xfemFsbG9jKCkganVzdCByZXR1cm5zIHRoZSBzYW1lIGRtYSBh ZGRyZXNzIGFzIHRoZSBsYXN0IHNlZ21lbnQgZm9yCj4gcmluZzE6MHgyZDkyYjAwMC4gTGFzdCBw YXJ0IG9mIHRyYWNlIHNuaXBwZXQgaXMganVzdCBhbm90aGVyIHJpbmcgYmVpbmcgZnJlZWQuCgpB IGdlbnRsZSBwaW5nIG9uIHRoaXMuIEFueSBpZGVhIG9uIHdoYXQgdGhlIHByb2JsZW0gbWlnaHQg YmUgYW5kIGFueQpwb3NzaWJsZSBmaXg/Ci0tLQpyZWdhcmRzClN1ZGlwCi0tClRvIHVuc3Vic2Ny aWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2Ii IGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1v cmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWlu Zm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: usb HC busted? Date: Thu, 21 Jun 2018 01:53:32 +0100 Message-ID: <20180621005332.5uy74tkjoel6w4xy@debian> References: <6790b352-add3-5531-115c-15db6c9c744d@intel.com> <20180518130458.v73syr3fltdzdzzi@debian> <881d576b-c7c1-ef74-c6bc-68b81371e7e0@intel.com> <20180523212956.n4ztasdffg2aeaku@debian> <80eace7a-976d-65a5-a353-54a2b18edd06@linux.intel.com> <20180604152848.db3msouyi4ektvv6@debian> <06226ecb-baad-cc36-e9e3-797dabb0aa5e@linux.intel.com> <42ec4ab07d96b4302b875ac9c5eb76675bf85690.camel@linux.intel.com> <20180606164524.n4vb7xre6rykzxih@debian> <2e8829c2-850d-6bca-5f0c-58a809dc9499@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <2e8829c2-850d-6bca-5f0c-58a809dc9499-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mathias Nyman , Andy Shevchenko Cc: Mathias Nyman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Christoph Hellwig , Andy Shevchenko , lukaszx.szulc-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Mathias, Andy, On Thu, Jun 07, 2018 at 10:40:03AM +0300, Mathias Nyman wrote: > On 06.06.2018 19:45, Sudip Mukherjee wrote: > > Hi Andy, > > > > And we meet again. :) > > > > On Wed, Jun 06, 2018 at 06:36:35PM +0300, Andy Shevchenko wrote: > > > On Wed, 2018-06-06 at 17:12 +0300, Mathias Nyman wrote: > > > > On 04.06.2018 18:28, Sudip Mukherjee wrote: > > > > > On Thu, May 24, 2018 at 04:35:34PM +0300, Mathias Nyman wrote: > > > > > > > > > > > > > Odd and unlikely, but to me this looks like some issue in allocating > > > > dma memory > > > > from pool using dma_pool_zalloc() > > > > > > > > > > > > Here's the story: > > > > Sudip sees usb issues on a Intel Atom based board with 4.14.2 kernel. > > > > All tracing points to dma_pool_zalloc() returning the same dma address > > > > block on > > > > consecutive calls. > > > > > > > > In the failing case dma_pool_zalloc() is called 3 - 6us apart. > > > > > > > > <...>-26362 [002] .... 1186.756739: xhci_ring_mem_detail: MATTU > > > > xhci_segment_alloc dma @ 0x000000002d92b000 > > > > <...>-26362 [002] .... 1186.756745: xhci_ring_mem_detail: MATTU > > > > xhci_segment_alloc dma @ 0x000000002d92b000 > > > > <...>-26362 [002] .... 1186.756748: xhci_ring_mem_detail: MATTU > > > > xhci_segment_alloc dma @ 0x000000002d92b000 > > > > > > > > dma_pool_zalloc() is called from xhci_segment_alloc() in > > > > drivers/usb/host/xhci-mem.c > > > > see: > > > > https://elixir.bootlin.com/linux/v4.14.2/source/drivers/usb/host/xhci- > > > > mem.c#L52 > > > > > > > > prints above are custom traces added right after dma_pool_zalloc() > > > > > > For better understanding it would be good to have dma_pool_free() calls > > > debugged as well. > > > > Sudip has a full (394M unpacked) trace at: > https://drive.google.com/open?id=1h-3r-1lfjg8oblBGkzdRIq8z3ZNgGZx- > > But then it gets stuck, for the whole ring2 dma_pool_zalloc() just returns the same dma address as the last segment for > ring1:0x2d92b000. Last part of trace snippet is just another ring being freed. A gentle ping on this. Any idea on what the problem might be and any possible fix? -- regards Sudip