From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: of-simple: fix use-after-free on remove From: Johan Hovold Message-Id: <20180621082723.GU32411@localhost> Date: Thu, 21 Jun 2018 10:27:23 +0200 To: "Rafael J. Wysocki" Cc: Johan Hovold , "Rafael J. Wysocki" , Tony Lindgren , Felipe Balbi , Roger Quadros , Tero Kristo , Greg Kroah-Hartman , Alan Stern , "open list:ULTRA-WIDEBAND \(UWB\) SUBSYSTEM:" , "Nori, Sekhar" , Grygorii Strashko , Nishanth Menon , Linux PM List-ID: T24gVGh1LCBKdW4gMjEsIDIwMTggYXQgMTI6MzI6NTlBTSArMDIwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gT24gV2VkLCBKdW4gMjAsIDIwMTggYXQgNTo0NiBQTSwgSm9oYW4gSG92b2xk IDxqb2hhbkBrZXJuZWwub3JnPiB3cm90ZToKPiA+IE9uIFdlZCwgSnVuIDIwLCAyMDE4IGF0IDAy OjU0OjEwUE0gKzAyMDAsIFJhZmFlbCBKLiBXeXNvY2tpIHdyb3RlOgo+ID4+IE9uIFdlZG5lc2Rh eSwgSnVuZSAyMCwgMjAxOCAyOjIzOjQ2IFBNIENFU1QgSm9oYW4gSG92b2xkIHdyb3RlOgo+ID4+ ID4gT24gV2VkLCBKdW4gMjAsIDIwMTggYXQgMDI6MTY6NTlBTSAtMDcwMCwgVG9ueSBMaW5kZ3Jl biB3cm90ZToKPiA+PiA+ID4gSGksCj4gPj4gPiA+Cj4gPj4gPiA+IEFkZGluZyBSYWZhZWwgYW5k IGxpbnV4LXBtIHRvIENjIGFzIHdlbGwuCj4gPj4gPiA+Cj4gPj4gPiA+ICogRmVsaXBlIEJhbGJp IDxiYWxiaUBrZXJuZWwub3JnPiBbMTgwNjE5IDAxOjIzXToKPiA+PiA+ID4gPiBUaGlzIGlzIGEg ZGlyZWN0IGNvbnNlcXVlbmNlIG9mIG5vdCBwYXlpbmcgYXR0ZW50aW9uIHRvIHRoZSBvcmRlciBv Zgo+ID4+ID4gPiA+IHRoaW5ncy4gSWYgZHJpdmVyIHdlcmUgdG8gYXNzdW1lIHRoYXQgcG1fZG9t YWluLT5hY3RpdmF0ZSgpIHdvdWxkIGRvIHRoZQo+ID4+ID4gPiA+IHJpZ2h0IHRoaW5nIGZvciB0 aGUgZGV2aWNlIC0tIG1lYW5pbmcgdGhhdCBwcm9iZSB3b3VsZCBydW4gd2l0aCBhbgo+ID4+ID4g PiA+IGFjdGl2ZSBkZXZpY2UgLS0sIHRoZW4gd2Ugd291bGRuJ3QgbmVlZCB0aGF0IHBtX3J1bnRp bWVfZ2V0KCkgY2FsbCBvbgo+ID4+ID4gPiA+IHByb2JlIGF0IGFsbC4gUmF0aGVyIHdlIHdvdWxk IGZvbGxvdyB0aGUgc2VxdWVuY2U6Cj4gPj4gPiA+ID4KPiA+PiA+ID4gPiAgICAgICAgIHBtX3J1 bnRpbWVfZm9yYmlkKCkKPiA+PiA+ID4gPiAgICAgICAgIHBtX3J1bnRpbWVfc2V0X2FjdGl2ZSgp Cj4gPj4gPiA+ID4gICAgICAgICBwbV9ydW50aW1lX2VuYWJsZSgpCj4gPj4gPiA+ID4KPiA+PiA+ ID4gPiAgICAgICAgIC8qIGRvIHlvdXIgcHJvYmUgcm91dGluZSAqLwo+ID4+ID4gPiA+Cj4gPj4g PiA+ID4gICAgICAgICBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKQo+ID4+ID4gPiA+Cj4gPj4gPiA+ ID4gVGhlbiB5b3UgcmVtb3ZlIHlvdSB3b3VsZCBuZWVkIHRvIGNhbGwgcG1fcnVudGltZV9nZXRf bm9yZXN1bWUoKSB0bwo+ID4+ID4gPiA+IGJhbGFuY2Ugb3V0IHRoZSBwbV9ydW50aW1lX3B1dF9u b2lkbGUoKSB0aGVyZS4KPiA+PiA+Cj4gPj4gPiA+ID4gKElmIHlvdSBuZWVkIHRvIGtub3cgd2h5 IHRoZSBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKSwgcmVtZW1iZXIgdGhhdAo+ID4+ID4gPiA+IHBt X3J1bnRpbWVfc2V0X2FjdGl2ZSgpIGluY3JlbWVudHMgdGhlIHVzYWdlIGNvdW50ZXIsIHNvCj4g Pj4gPiA+ID4gcG1fcnVudGltZV9wdXRfbm9pZGxlIGlzIGJhc2ljYWxseSBhbGxvd2luZyBwbV9y dW50aW1lIHRvIGhhcHBlbiBhcyBzb29uCj4gPj4gPiA+ID4gYXMgdXNlcnNwYWNlIHdyaXRlcyAi YXV0byIgdG8gL3N5cy8uLi4uL3Bvd2VyL2NvbnRyb2wpCj4gPj4gPgo+ID4+ID4gVGhhdCdzIG5v dCBjb3JyZWN0OyBwbV9ydW50aW1lX3NldF9hY3RpdmUoKSBvbmx5IGluY3JlbWVudHMgdGhlIHVz YWdlCj4gPj4gPiBjb3VudGVyIG9mIGEgcGFyZW50ICh1bmRlciBzb21lIGNpcmN1bXN0YW5jZXMp LCBzbyB1bmxlc3MgeW91IGhhdmUgYnVzCj4gPj4gPiBjb2RlIGluY3JlbWVudGluZyB0aGUgdXNh Z2UgY291bnRlciBiZWZvcmUgcHJvYmUsIHRoZSBhYm92ZQo+ID4+ID4gcG1fcnVudGltZV9wdXRf bm9pZGxlKCkgd291bGQgYWN0dWFsbHkgaW50cm9kdWNlIGFuIGltYmFsYW5jZS4KPiA+Pgo+ID4+ IE5vLCBpdCB3b3VsZG4ndC4gIEl0IGJhbGFuY2VzIHRoZSBpbmNyZW1lbnRhdGlvbiBpbiBwbV9y dW50aW1lX2ZvcmJpZCgpLgo+ID4KPiA+IFJpZ2h0LCBidXQgZXZlbiBpZiB5b3UgdGFrZSB0aGUg d2hvbGUgc2VxdWVuY2UsIHdoaWNoIGluY2x1ZGVkCj4gPiBwbV9ydW50aW1lX2ZvcmJpZCgpLCBj b25zaWRlciB3aGF0IGhhcHBlbnMgd2hlbiBwbV9ydW50aW1lX2FsbG93KCkgaXMKPiA+IGxhdGVy IGNhbGxlZCB0aHJvdWdoIHN5c2ZzIChzZWUgYmVsb3cpLgo+ID4KPiA+PiA+IEFuZCBub3RlIHRo YXQgdGhhdCdzIGFsc28gdGhlIGNhc2UgZXZlbiBpZiB5b3UgbWVhbnQgdG8gc2F5IHRoYXQKPiA+ PiA+ICpwbV9ydW50aW1lX2ZvcmJpZCgpKiBpbmNyZW1lbnRzIHRoZSB1c2FnZSBjb3VudGVyICh3 aGljaCBpdCBkb2VzKS4KPiA+Pgo+ID4+IFdoeSBpcyBpdD8KPiA+Pgo+ID4+IFN1cmVseSwgYWZ0 ZXIKPiA+Pgo+ID4+IHBtX3J1bnRpbWVfZm9yYmlkKGRldik7Cj4gPj4gcG1fcnVudGltZV9wdXRf bm9pZGxlKGRldik7Cj4gPj4KPiA+PiB0aGUgcnVudGltZSBQTSB1c2FnZSBjb3VudGVyIG9mIGRl diB3aWxsIGJlIHRoZSBzYW1lIGFzIGJlZm9yZSwgd29uJ3QgaXQ/Cj4gPgo+ID4gU3VyZSwgYnV0 IHRoZSBpbWJhbGFuY2UsIG9yIHJhdGhlciBpbmNvbnNpc3RlbnQgc3RhdGUsIGhhcyBhbHJlYWR5 IGJlZW4KPiA+IGludHJvZHVjZWQuCj4gPgo+ID4gQ29uc2lkZXIgdGhlIGZvbGxvd2luZyBzZXF1 ZW5jZSBvZiBldmVudHM6Cj4gPgo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHVzYWdlIGNvdW50Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMAo+ID4gcHJvYmUoKQo+ID4gICAgICAgICBwbV9ydW50aW1lX2ZvcmJpZCgpICAgICAg ICAgICAgIDEKPiA+ICAgICAgICAgcG1fcnVudGltZV9zZXRfYWN0aXZlKCkKPiA+ICAgICAgICAg cG1fcnVudGltZV9lbmFibGUoKQo+ID4gICAgICAgICBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKSAg ICAgICAgIDAKPiA+Cj4gPiBIZXJlIG5vdGhpbmcgaXMgcHJldmVudGluZyB0aGUgZGV2aWNlIGZy b20gcnVudGltZSBzdXNwZW5kaW5nLCBkZXNwaXRlCj4gPiBydW50aW1lIFBNIGJlaW5nIGZvcmJp ZGRlbi4gSW4gZmFjdCwgaXQgd2lsbCB0eXBpY2FsbHkgYmUgc3VzcGVuZGVkIGR1ZQo+ID4gdG8g dGhlIHBtX3JlcXVlc3RfaWRsZSgpIGluIGRyaXZlcl9wcm9iZV9kZXZpY2UoKS4gSWYgbGF0ZXIg d2UgaGF2ZToKPiA+Cj4gPiBlY2hvIGF1dG8gPiBwb3dlci9jb250cm9sCj4gPiAgICAgICAgIHBt X3J1bnRpbWVfYWxsb3coKSAgICAgICAgICAgICAgLTEKPiAKPiBPSywgeW91IGhhdmUgYSBwb2lu dC4KPiAKPiBBZnRlciBjYWxsaW5nIHBtX3J1bnRpbWVfZm9yYmlkKCkgdGhlIGRyaXZlciBzaG91 bGQgYWxsb3cgdXNlciBzcGFjZQo+IHRvIHVuYmxvY2sgcnVudGltZSBQTSBmb3IgdGhlIGRldmlj ZSAtIG9yIGNhbGwgcG1fcnVudGltZV9hbGxvdygpCj4gaXRzZWxmLgoKUmlnaHQsIHRoZSB1c2Fn ZSBjb3VudCBpbmNyZW1lbnQgZG9uZSBieSBmb3JiaWQoKSBzaG91bGQgb25seSBiZQpiYWxhbmNl ZCBieSBhbGxvdygpLgoKPiBbY3V0XQo+IAo+ID4KPiA+IEFuZCBpZiBydW50aW1lIHBtIGlzIGxh dGVyIGFnYWluIGZvcmJpZGRlbjoKPiA+Cj4gPiBlY2hvIG9uID4gcG93ZXIvY29udHJvbAo+ID4g ICAgICAgICBwbV9ydW50aW1lX2ZvcmJpZCgpICAgICAgICAgICAgIDAKPiA+Cj4gPiB0aGVuIHRo ZSBkZXZpY2Ugd2lsbCBub3QgYmUgcmVzdW1lZC4KPiAKPiBCdXQgSSBkb24ndCBxdWl0ZSBzZWUg d2h5IHRoYXQgd2lsbCBiZSB0aGUgY2FzZS4gIHJwbV9yZXN1bWUoKSB3aWxsCj4gc3RpbGwgYmUg Y2FsbGVkIGFuZCBpdCBkb2Vzbid0IGxvb2sgYXQgdGhlIHVzYWdlIGNvdW50ZXIuCgpZb3UncmUg cmlnaHQsIEkgbGVmdCBvdXQgc29tZSBpbXBvcnRhbnQgZGV0YWlscyBhbmQganVtcGVkIHRvIHRo ZQpjb25jbHVzaW9uLiBBcyB5b3UgcG9pbnQgb3V0LCB0aGUgZGV2aWNlIHdpbGwgYmUgdW5jb25k aXRpb25hbGx5CnJlc3VtZWQsIGJ1dCBkdWUgdG8gdGhlIHVzYWdlIGNvdW50ZXIgYmVpbmcgemVy byB0aGUgaWRsZSBub3RpZmljYXRpb24KcXVldWVkIGJ5IHJwbV9yZXN1bWUoKSB3aWxsIHR5cGlj YWxseSBzdXNwZW5kIGl0IHN0cmFpZ2h0IGF3YXkgZGVzcGl0ZQpydW50aW1lIHBtIGJlaW5nIGZv cmJpZGRlbiAoY2YuIHRoZSBpZGxlIG5vdGlmaWNhdGlvbiBpc3N1ZWQgYnkgZHJpdmVyCmNvcmUg YWZ0ZXIgcHJvYmUoKSByZXR1cm5zKS4KCkpvaGFuCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRo aXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9k eSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9t byBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK